fix: dont save ids when copying blocks and comments #9255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Will the keyboard nav tests need to be updated as well (per the failures)? |
Contributor
Author
yep RaspberryPiFoundation/blockly-keyboard-experimentation#681 |
maribethb
merged commit c661dd1
into
RaspberryPiFoundation:develop
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9226
Proposed Changes
Don't save IDs when copying blocks and workspace comments
Reason for Changes
Saving the IDs doesn't make sense and can break some multi-workspace scenarios:
imagine you are mirroring events into a workspace, and you paste a block into one workspace but a block with that id already exists on the mirroring workspace.
if you're just pasting into the same workspace, the id won't be the same anyway because pasting will detect there's an id collision and automatically get a new one. we might as well always get a new id when pasting instead.
Test Coverage
I also tested this with the additional webdriver tests I added in #9254 and those also pass
Documentation
Additional Information