feat!: Temp branch for screen reader concepts [DO NOT MERGE] #9262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to never be merged as-is. This branch only exists for reference and staging purposes.
Conflicts: core/bubbles/bubble.ts core/workspace_svg.ts
github-actions
bot
added
breaking change
BenHenning
commented
Jul 29, 2025
Comment on lines
+578
to
+585
| const nodeRole = node.getAriaRole(); | ||
| const nodeLabel = node.getAriaLabel(); | ||
| if (aria.getRole(elem) !== nodeRole) { | ||
| aria.setRole(elem, nodeRole); | ||
| } | ||
| if (aria.getState(elem, aria.State.LABEL) !== nodeLabel) { | ||
| aria.setState(elem, aria.State.LABEL, nodeLabel); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This can't happen this late. Even more than tab index, this needs to be set as early as possible for an element in order to set up the a11y node tree correctly.
Collaborator
Author
|
This has been functionally moved over to RaspberryPiFoundation/blockly-keyboard-experimentation#684 so closing it. It will still serve well as a reference for future long-term design considerations. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary staging branch for core changes that will (hopefully) eventually be entirely moved to RaspberryPiFoundation/blockly-keyboard-experimentation#684.
Note that this may also serve as a reference for future longer-term design changes to core to accommodate screen reader feature requirements.
This will be closed once RaspberryPiFoundation/blockly-keyboard-experimentation#684 is ready for review.