fix: fix broken dragging in non-zelos renderers #9368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
changed the title
Contributor
Author
|
Note: kb tests will pass once RaspberryPiFoundation/blockly-keyboard-experimentation#730 is merged, and in that PR, the tests won't pass until this PR is merged. Fun! |
gonfunko
approved these changes
Sep 16, 2025
maribethb
merged commit 8da7d17
into
RaspberryPiFoundation:add-screen-reader-support-experimental
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9367
Proposed Changes
Adds guard against undefined nextSibling
Test Coverage
Manually tested with geras, and linked against kbe and verified that tests pass there.