Skip to content

Conversation

@gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#762

Proposed Changes

This PR modifies the locations that are visited when navigating using the up arrow key to match those that are visited by the down arrow key, but in reverse. Specifically, when navigating backwards, we now:

  • Visit the last (empty) next connection in a block stack within a statement input
  • Do not visit the first (empty or filled) value input in a block with statement inputs, because this results in redundant screenreader output with the block itself. These inputs/blocks are also skipped when navigating with the down arrow for the same reason
  • Do not focus the rightmost nested block in a statement block; instead, focus on the root statement block itself.

@gonfunko gonfunko requested a review from a team as a code owner October 24, 2025 21:48
@gonfunko gonfunko requested review from maribethb and removed request for a team October 24, 2025 21:48
@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 24, 2025
@maribethb
Copy link
Contributor

I think a similar set of tests is failing on my PR against this branch. Not sure what's up with them, although at least this PR is plausible that some of the tests need updating.

@gonfunko
Copy link
Contributor Author

Fixed the tests in RaspberryPiFoundation/blockly-keyboard-experimentation#766, which should fully pass once this is merged.

@gonfunko gonfunko merged commit 7e77b10 into add-screen-reader-support-experimental Oct 27, 2025
11 of 13 checks passed
@gonfunko gonfunko deleted the previous-nav branch October 27, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants