Skip to content

Commit 065ce6c

Browse files
committed
fix: enable threads in monitors sb2 to sb3 test
1 parent c46c67d commit 065ce6c

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

packages/scratch-vm/test/integration/monitors_sb2_to_sb3.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,15 @@ test('saving and loading sb2 project with monitors preserves sliderMin and slide
1414
vm.attachStorage(makeTestStorage());
1515

1616
vm.on('playgroundData', e /* eslint-disable-line no-unused-vars */ => {
17-
// TODO related to above TODO, comment these back in when we figure out
18-
// why running threads doesn't work with this test
19-
20-
// const threads = JSON.parse(e.threads);
17+
const threads = JSON.parse(e.threads);
2118
// All monitors should create threads that finish during the step and
2219
// are revoved from runtime.threads.
23-
// t.equal(threads.length, 0);
20+
t.equal(threads.length, 0);
2421

2522
// we care that the last step updated the right number of monitors
2623
// we don't care whether the last step ran other threads or not
27-
// const lastStepUpdatedMonitorThreads = vm.runtime._lastStepDoneThreads.filter(thread => thread.updateMonitor);
28-
// t.equal(lastStepUpdatedMonitorThreads.length, 8);
24+
const lastStepUpdatedMonitorThreads = vm.runtime._lastStepDoneThreads.filter(thread => thread.updateMonitor);
25+
t.equal(lastStepUpdatedMonitorThreads.length, 8);
2926

3027
// There should be one additional hidden monitor that is in the monitorState but
3128
// does not start a thread.

0 commit comments

Comments
 (0)