comment to clarify max_fr of bvcs overshoot

TomGeorge1234 · TomGeorge1234 · commit 0eaa4142e64f · 2024-03-28T11:33:30.000Z
diff --git a/ratinabox/Neurons.py b/ratinabox/Neurons.py
@@ -1488,6 +1488,8 @@ class BoundaryVectorCells(VectorCells):
         "n": 10,
         "name": "BoundaryVectorCells",
         "dtheta": 2, #angular resolution in degrees used for integration over all angles (smaller is more accurate but slower)
+        "max_fr":1.0, # note the max_fr of a BVC is environment-dependent so is epirically estimated at initialisation by calculating the firing rate at all points in the environment, this can lead to small overshoots (see issue #110 for discussion)
+        "min_fr":0.0,
     }
 
     def __init__(self, Agent, params={}):

Original file line number	Diff line number	Diff line change
`@@ -1488,6 +1488,8 @@ class BoundaryVectorCells(VectorCells):`
`1488`	`1488`	`"n": 10,`
`1489`	`1489`	`"name": "BoundaryVectorCells",`
`1490`	`1490`	`"dtheta": 2, #angular resolution in degrees used for integration over all angles (smaller is more accurate but slower)`
	`1491`	`+ "max_fr":1.0, # note the max_fr of a BVC is environment-dependent so is epirically estimated at initialisation by calculating the firing rate at all points in the environment, this can lead to small overshoots (see issue #110 for discussion)`
	`1492`	`+ "min_fr":0.0,`
`1491`	`1493`	`}`
`1492`	`1494`
`1493`	`1495`	`def __init__(self, Agent, params={}):`