Squashed commit of the following:

wzrdx · wzrdx · commit 0aa641bd81b3 · 2025-10-23T16:03:53.000+03:00
commit ef6ddf7 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 16:03:29 2025 +0300 fix: Refactor service tag so it's serializable commit 38b2723 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:56:15 2025 +0300 fix: GpuType schema bug commit f437d25 Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:37:14 2025 +0300 fix: Allow editing the allowReplicationInTheWild field of a job commit 6a18a0f Author: wzrdx <128477299+wzrdx@users.noreply.github.com> Date: Thu Oct 23 15:26:05 2025 +0300 fix: Edit job failing for native jobs with chainstore response = false
diff --git a/src/components/create-job/steps/deployment/ServiceDeployment.tsx b/src/components/create-job/steps/deployment/ServiceDeployment.tsx
@@ -6,6 +6,7 @@ import InputWithLabel from '@shared/InputWithLabel';
 import ServiceInputsSection from '@shared/jobs/ServiceInputsSection';
 import TargetNodesCard from '@shared/jobs/target-nodes/TargetNodesCard';
 import { JobSpecifications, JobType } from '@typedefs/deeploys';
+import clsx from 'clsx';
 import { useEffect } from 'react';
 import { useFormContext } from 'react-hook-form';
 
@@ -27,7 +28,23 @@ function ServiceDeployment({ isEditingJob }: { isEditingJob?: boolean }) {
 
     return (
         <div className="col gap-6">
-            <SlateCard title="Service Identity" label={containerOrWorkerType?.tag}>
+            <SlateCard
+                title="Service Identity"
+                label={
+                    containerOrWorkerType?.tag ? (
+                        <div
+                            className={clsx(
+                                'center-all h-[30px] rounded-md bg-blue-100 px-2',
+                                containerOrWorkerType.tag.bgClass,
+                            )}
+                        >
+                            <div className={clsx('row gap-1.5', containerOrWorkerType.tag.textClass)}>
+                                <div className="compact">{containerOrWorkerType.tag.text}</div>
+                            </div>
+                        </div>
+                    ) : null
+                }
+            >
                 <div className="flex gap-4">
                     <InputWithLabel name="deployment.jobAlias" label="Alias" placeholder="Service" />
                 </div>
diff --git a/src/components/create-job/steps/specifications/GenericSpecifications.tsx b/src/components/create-job/steps/specifications/GenericSpecifications.tsx
@@ -27,11 +27,7 @@ export default function GenericSpecifications({
 
                 <SelectGPU jobType={JobType.Generic} isDisabled={isEditingJob} />
 
-                <ContainerResourcesInfo
-                    jobType={JobType.Generic}
-                    name="specifications.containerType"
-                    options={genericContainerTypes}
-                />
+                <ContainerResourcesInfo name="specifications.containerType" options={genericContainerTypes} />
             </SlateCard>
 
             <SpecsNodesSection
diff --git a/src/components/create-job/steps/specifications/NativeSpecifications.tsx b/src/components/create-job/steps/specifications/NativeSpecifications.tsx
@@ -27,7 +27,7 @@ export default function NativeSpecifications({
 
                 <SelectGPU jobType={JobType.Native} isDisabled={isEditingJob} />
 
-                <ContainerResourcesInfo jobType={JobType.Native} name="specifications.workerType" options={nativeWorkerTypes} />
+                <ContainerResourcesInfo name="specifications.workerType" options={nativeWorkerTypes} />
             </SlateCard>
 
             <SpecsNodesSection
diff --git a/src/components/create-job/steps/specifications/ServiceSpecifications.tsx b/src/components/create-job/steps/specifications/ServiceSpecifications.tsx
@@ -6,7 +6,6 @@ import SelectContainerOrWorkerType from '@shared/jobs/SelectContainerOrWorkerTyp
 import JobTags from '@shared/jobs/target-nodes/JobTags';
 import NumberInputWithLabel from '@shared/NumberInputWithLabel';
 import SelectWithLabel from '@shared/SelectWithLabel';
-import { JobType } from '@typedefs/deeploys';
 
 export default function ServiceSpecifications({ isEditingJob }: { isEditingJob?: boolean }) {
     return (
@@ -19,11 +18,7 @@ export default function ServiceSpecifications({ isEditingJob }: { isEditingJob?:
                     isDisabled={isEditingJob}
                 />
 
-                <ContainerResourcesInfo
-                    jobType={JobType.Service}
-                    name="specifications.containerType"
-                    options={serviceContainerTypes}
-                />
+                <ContainerResourcesInfo name="specifications.containerType" options={serviceContainerTypes} />
             </SlateCard>
 
             <SlateCard>
diff --git a/src/components/edit-job/ReviewAndConfirm.tsx b/src/components/edit-job/ReviewAndConfirm.tsx
@@ -16,12 +16,12 @@ type JobFormValues = z.infer<typeof jobSchema>;
 type StepKey = 'specifications' | 'costAndDuration' | 'deployment';
 
 const hasDirtyFields = (dirtyValue: unknown): boolean => {
-    if (!dirtyValue) {
-        return false;
+    if (typeof dirtyValue === 'boolean') {
+        return dirtyValue;
     }
 
-    if (dirtyValue === true) {
-        return true;
+    if (!dirtyValue) {
+        return false;
     }
 
     if (Array.isArray(dirtyValue)) {
diff --git a/src/components/job/config/JobConfigurations.tsx b/src/components/job/config/JobConfigurations.tsx
@@ -7,7 +7,7 @@ import StyledSelect from '@shared/StyledSelect';
 import { JobConfig } from '@typedefs/deeployApi';
 import { JobType, RunningJobWithResources } from '@typedefs/deeploys';
 import _, { isEmpty } from 'lodash';
-import { useEffect, useState } from 'react';
+import { useState } from 'react';
 import JobDynamicEnvSection from '../JobDynamicEnvSection';
 import JobFileVolumesSection from '../JobFileVolumesSection';
 import JobKeyValueSection from '../JobKeyValueSection';
@@ -41,10 +41,6 @@ export default function JobConfigurations({ job }: { job: RunningJobWithResource
 
     const config = pluginConfig.value;
 
-    useEffect(() => {
-        console.log('Config', pluginConfig);
-    }, [pluginConfig]);
-
     return (
         <BorderedCard isLight={false} disableWrapper>
             <div className="col gap-3 p-4">
diff --git a/src/data/containerResources.tsx b/src/data/containerResources.tsx
@@ -19,7 +19,11 @@ export type Service = ContainerOrWorkerType & {
     port?: number;
     image?: string;
     dbSystem?: string;
-    tag?: React.ReactNode;
+    tag?: {
+        text: string;
+        bgClass: string;
+        textClass: string;
+    };
     inputs?: { key: string; label: string }[];
 };
 
@@ -44,30 +48,6 @@ export type RunningJobResources = {
     jobType: JobType;
 };
 
-const getPostgresTag = () => (
-    <div className="center-all h-[30px] rounded-md bg-blue-100 px-2">
-        <div className="row gap-1.5 text-blue-600">
-            <div className="compact">PostgreSQL</div>
-        </div>
-    </div>
-);
-
-const getMySQLTag = () => (
-    <div className="center-all h-[30px] rounded-md bg-orange-100 px-2">
-        <div className="row gap-0.5 text-orange-600">
-            <div className="compact">MySQL</div>
-        </div>
-    </div>
-);
-
-const getMongoDBTag = () => (
-    <div className="center-all h-[30px] rounded-md bg-green-100 px-2">
-        <div className="row gap-0.5 text-green-600">
-            <div className="compact">MongoDB</div>
-        </div>
-    </div>
-);
-
 export const genericContainerTypes: ContainerOrWorkerType[] = [
     {
         id: 1,
@@ -273,7 +253,7 @@ export const serviceContainerTypes: Service[] = [
         port: 5432,
         image: 'postgres:17',
         dbSystem: 'PostgreSQL',
-        tag: getPostgresTag(),
+        tag: { text: 'PostgreSQL', bgClass: 'bg-blue-100', textClass: 'text-blue-600' },
         inputs: [{ key: 'POSTGRES_PASSWORD', label: 'PostgreSQL Password' }],
     },
     {
@@ -292,7 +272,7 @@ export const serviceContainerTypes: Service[] = [
         port: 5432,
         image: 'postgres:17',
         dbSystem: 'PostgreSQL',
-        tag: getPostgresTag(),
+        tag: { text: 'PostgreSQL', bgClass: 'bg-blue-100', textClass: 'text-blue-600' },
         inputs: [{ key: 'POSTGRES_PASSWORD', label: 'PostgreSQL Password' }],
     },
     {
@@ -311,7 +291,7 @@ export const serviceContainerTypes: Service[] = [
         port: 3306,
         image: 'mysql',
         dbSystem: 'MySQL',
-        tag: getMySQLTag(),
+        tag: { text: 'MySQL', bgClass: 'bg-orange-100', textClass: 'text-orange-600' },
         inputs: [{ key: 'MYSQL_ROOT_PASSWORD', label: 'MySQL Root Password' }],
     },
     {
@@ -330,7 +310,7 @@ export const serviceContainerTypes: Service[] = [
         port: 3306,
         image: 'mysql',
         dbSystem: 'MySQL',
-        tag: getMySQLTag(),
+        tag: { text: 'MySQL', bgClass: 'bg-orange-100', textClass: 'text-orange-600' },
         inputs: [{ key: 'MYSQL_ROOT_PASSWORD', label: 'MySQL Root Password' }],
     },
     {
@@ -349,7 +329,7 @@ export const serviceContainerTypes: Service[] = [
         port: 27017,
         image: 'mongodb',
         dbSystem: 'MongoDB',
-        tag: getMongoDBTag(),
+        tag: { text: 'MongoDB', bgClass: 'bg-green-100', textClass: 'text-green-600' },
         inputs: [
             { key: 'MONGO_INITDB_ROOT_USERNAME', label: 'MongoDB Root Username' },
             { key: 'MONGO_INITDB_ROOT_PASSWORD', label: 'MongoDB Root Password' },
@@ -371,7 +351,7 @@ export const serviceContainerTypes: Service[] = [
         port: 27017,
         image: 'mongodb',
         dbSystem: 'MongoDB',
-        tag: getMongoDBTag(),
+        tag: { text: 'MongoDB', bgClass: 'bg-green-100', textClass: 'text-green-600' },
         inputs: [
             { key: 'MONGO_INITDB_ROOT_USERNAME', label: 'MongoDB Root Username' },
             { key: 'MONGO_INITDB_ROOT_PASSWORD', label: 'MongoDB Root Password' },
diff --git a/src/lib/deeploy-utils.ts b/src/lib/deeploy-utils.ts
@@ -106,7 +106,9 @@ export const getContainerOrWorkerType = (jobType: JobType, specifications: JobSp
 };
 
 export const getGpuType = (specifications: GenericJobSpecifications | NativeJobSpecifications): GpuType | undefined => {
-    return specifications.gpuType ? gpuTypes.find((type) => type.name === specifications.gpuType) : undefined;
+    return specifications.gpuType && specifications.gpuType !== ''
+        ? gpuTypes.find((type) => type.name === specifications.gpuType)
+        : undefined;
 };
 
 export const downloadDataAsJson = (data: any, filename: string) => {
diff --git a/src/pages/deeploys/job/EditJob.tsx b/src/pages/deeploys/job/EditJob.tsx
@@ -180,8 +180,10 @@ export default function EditJob() {
             }
 
             if (
-                updatePipelineResponse.status === 'success' &&
-                (increasingTargetNodes ? scaleUpWorkersResponse.status === 'success' : true)
+                (updatePipelineResponse.status === 'success' || updatePipelineResponse.status === 'command_delivered') &&
+                (increasingTargetNodes
+                    ? scaleUpWorkersResponse.status === 'success' || scaleUpWorkersResponse.status === 'command_delivered'
+                    : true)
             ) {
                 deeployFlowModalRef.current?.progress('done');
                 setFetchAppsRequired(true);
@@ -225,8 +227,12 @@ export default function EditJob() {
                             text = 'Request timed out';
                         } else if (response.error) {
                             text = response.error;
-                        } else if (response.status && response.status !== 'success') {
-                            text = `Request failed with status ${response.status}`;
+                        } else if (
+                            response.status &&
+                            response.status !== 'success' &&
+                            response.status !== 'command_delivered'
+                        ) {
+                            text = `Request failed with status: ${response.status}`;
                         }
 
                         if (!text) {
diff --git a/src/shared/jobs/ContainerResourcesInfo.tsx b/src/shared/jobs/ContainerResourcesInfo.tsx
@@ -1,17 +1,15 @@
 import { ContainerOrWorkerType, GpuType, gpuTypes } from '@data/containerResources';
 import Label from '@shared/Label';
 import { SmallTag } from '@shared/SmallTag';
-import { JobType } from '@typedefs/deeploys';
 import { useEffect, useState } from 'react';
 import { useFormContext } from 'react-hook-form';
 
 interface Props {
-    jobType: JobType;
     name: string;
     options: ContainerOrWorkerType[];
 }
 
-export default function ContainerResourcesInfo({ jobType, name, options }: Props) {
+export default function ContainerResourcesInfo({ name, options }: Props) {
     const { watch } = useFormContext();
 
     const containerOrWorkerTypeName: string = watch(name);
diff --git a/src/shared/jobs/SelectGPU.tsx b/src/shared/jobs/SelectGPU.tsx
@@ -35,7 +35,7 @@ export default function SelectGPU({ jobType, isDisabled }: Props) {
             setSupportedGpuTypes(supportedGpuTypes);
 
             if (!supportedGpuTypes.length) {
-                setValue('specifications.gpuType', '');
+                setValue('specifications.gpuType', undefined);
             }
         }
     }, [containerOrWorkerTypeValue]);
diff --git a/src/shared/jobs/target-nodes/TargetNodesCard.tsx b/src/shared/jobs/target-nodes/TargetNodesCard.tsx
@@ -66,7 +66,7 @@ function TargetNodesCard({ isEditingJob }: { isEditingJob?: boolean }) {
                         <Checkbox
                             isSelected={allowReplicationInTheWild}
                             onValueChange={(value) => {
-                                setValue('deployment.allowReplicationInTheWild', value);
+                                setValue('deployment.allowReplicationInTheWild', value, { shouldDirty: true });
                             }}
                         >
                             <div className="compact text-slate-600">Allow deployment beyond chosen nodes</div>

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,12 @@ type JobFormValues = z.infer<typeof jobSchema>;`
`16`	`16`	`type StepKey = 'specifications' \| 'costAndDuration' \| 'deployment';`
`17`	`17`
`18`	`18`	`const hasDirtyFields = (dirtyValue: unknown): boolean => {`
`19`		`- if (!dirtyValue) {`
`20`		`- return false;`
	`19`	`+ if (typeof dirtyValue === 'boolean') {`
	`20`	`+ return dirtyValue;`
`21`	`21`	`}`
`22`	`22`
`23`		`- if (dirtyValue === true) {`
`24`		`- return true;`
	`23`	`+ if (!dirtyValue) {`
	`24`	`+ return false;`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`if (Array.isArray(dirtyValue)) {`