Merge pull request The-OpenROAD-Project#8330 from The-OpenROAD-Project-staging/odb-defout-coverity

odb: fix Coverity warnings in defout

Author: maliberty

src/odb/src/defout/defout_impl.cpp

@@ -763,6 +763,7 @@ void DefOut::Impl::writeRegions(dbBlock* block)
       *_out << " ( " << defdist(box->xMin()) << " " << defdist(box->yMin())
             << " ) ( " << defdist(box->xMax()) << " " << defdist(box->yMax())
             << " )";
+      ++cnt;
     }
 
     switch ((dbRegionType::Value) region->getRegionType()) {
@@ -1035,25 +1036,24 @@ void DefOut::Impl::writeBPin(dbBPin* bpin, int cnt)
       *_out << " + LAYER " << lname << " ( " << xMin << " " << yMin << " ) ( "
             << xMax << " " << yMax << " )";
     } else {
-      std::string layer_name = lname;
       if (_version == DefOut::DEF_5_8) {
         uint mask = box->getLayerMask();
         if (mask != 0) {
           // add mask information to layer name
-          layer_name += " MASK " + std::to_string(mask);
+          lname += " MASK " + std::to_string(mask);
         }
       }
       if (bpin->hasEffectiveWidth()) {
         int w = defdist(bpin->getEffectiveWidth());
-        *_out << " + LAYER " << layer_name << " DESIGNRULEWIDTH " << w << " ( "
+        *_out << " + LAYER " << lname << " DESIGNRULEWIDTH " << w << " ( "
               << xMin << " " << yMin << " ) ( " << xMax << " " << yMax << " )";
       } else if (bpin->hasMinSpacing()) {
         int s = defdist(bpin->getMinSpacing());
-        *_out << " + LAYER " << layer_name << " SPACING " << s << " ( " << xMin
+        *_out << " + LAYER " << lname << " SPACING " << s << " ( " << xMin
               << " " << yMin << " ) ( " << xMax << " " << yMax << " )";
       } else {
-        *_out << " + LAYER " << layer_name << " ( " << xMin << " " << yMin
-              << " ) ( " << xMax << " " << yMax << " )";
+        *_out << " + LAYER " << lname << " ( " << xMin << " " << yMin << " ) ( "
+              << xMax << " " << yMax << " )";
       }
     }
   }
@@ -2068,6 +2068,7 @@ void DefOut::Impl::writeProperties(dbObject* object)
     std::string name = prop->getName();
     *_out << name << " ";
     writePropValue(prop);
+    ++cnt;
   }
 }
 

src/odb/test/def_parser.defok

@@ -90,10 +90,12 @@ NONDEFAULTRULES 1 ;
       + VIA M3_M2_via
       + VIARULE M2_M1
       + MINCUTS via1 2
-    + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 realrangeprop 25.25     ;
+    + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 
+    realrangeprop 25.25     ;
 END NONDEFAULTRULES
 REGIONS 2 ;
-    - region1 ( -500 -500 ) ( 300 100 ) ( 500 500 ) ( 1000 1000 ) + TYPE FENCE + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 realrangeprop 25.25  ;
+    - region1 ( -500 -500 ) ( 300 100 ) ( 500 500 ) ( 1000 1000 ) + TYPE FENCE + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 
+    realrangeprop 25.25  ;
     - region2 ( 4000 0 ) ( 5000 1000 ) + TYPE GUIDE ;
 END REGIONS
 COMPONENTS 12 ;
@@ -186,6 +188,7 @@ NETS 24 ;
     - out[8] ( PIN out[8] ) ( _d8_ Q ) + USE SIGNAL ;
 END NETS
 GROUPS 1 ;
-    - group1 _d0_ _g0_ + REGION region1 + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 realrangeprop 25.25  ;
+    - group1 _d0_ _g0_ + REGION region1 + PROPERTY strprop "aString" intprop 1 realprop 1.1 intrangeprop 25 
+    realrangeprop 25.25  ;
 END GROUPS
 END DESIGN