pdn: add reason to dummy via

Signed-off-by: Peter Gadfort <[email protected]>

Author: gadfort

src/pdn/src/connect.cpp

@@ -456,7 +456,17 @@ void Connect::makeVia(odb::dbSWire* wire,
   // check if off grid and don't add one if it is
   if (!TechLayer::checkIfManufacturingGrid(tech, x)
       || !TechLayer::checkIfManufacturingGrid(tech, y)) {
-    DbGenerateDummyVia dummy_via(this, intersection, layer0_, layer1_, true);
+    DbGenerateDummyVia dummy_via(
+        this,
+        intersection,
+        layer0_,
+        layer1_,
+        true,
+        fmt::format("({:.4f}, {:.4f}) is off manufacturing grid of {:.4f}",
+                    x / static_cast<double>(tech->getLefUnits()),
+                    y / static_cast<double>(tech->getLefUnits()),
+                    tech->getManufacturingGrid()
+                        / static_cast<double>(tech->getLefUnits())));
     dummy_via.generate(
         wire->getBlock(), wire, type, 0, 0, ongrid_, grid_->getLogger());
     return;
@@ -559,7 +569,7 @@ void Connect::makeVia(odb::dbSWire* wire,
         odb::Rect area = intersection;
         xfm.apply(area);
         stack.push_back(
-            new DbGenerateDummyVia(this, area, layer0_, layer1_, false));
+            new DbGenerateDummyVia(this, area, layer0_, layer1_, false, ""));
         break;
       }
       stack.push_back(new_via);

src/pdn/src/via.cpp

@@ -1108,12 +1108,14 @@ DbGenerateDummyVia::DbGenerateDummyVia(Connect* connect,
                                        const odb::Rect& shape,
                                        odb::dbTechLayer* bottom,
                                        odb::dbTechLayer* top,
-                                       bool add_report)
+                                       bool add_report,
+                                       const std::string& reason)
     : connect_(connect),
       add_report_(add_report),
       shape_(shape),
       bottom_(bottom),
-      top_(top)
+      top_(top),
+      reason_(reason)
 {
 }
 
@@ -1132,11 +1134,13 @@ DbVia::ViaLayerShape DbGenerateDummyVia::generate(
   xfm.apply(via_area);
   logger->warn(utl::PDN,
                110,
-               "No via inserted between {} and {} at {} on {}",
+               "No via inserted between {} and {} at {} on {}{}{}",
                bottom_->getName(),
                top_->getName(),
                Shape::getRectText(via_area, block->getDbUnitsPerMicron()),
-               wire->getNet()->getName());
+               wire->getNet()->getName(),
+               reason_.empty() ? "" : ": ",
+               reason_);
   if (add_report_) {
     connect_->addFailedVia(failedViaReason::BUILD, via_area, wire->getNet());
   }
@@ -1491,8 +1495,9 @@ bool ViaGenerator::checkMinCuts(odb::dbTechLayer* layer, int width) const
              utl::PDN,
              "MinCut",
              1,
-             "Layer {} of width {:.4f} has {} min cut rules.",
+             "Layer {} (below {}) of width {:.4f} has {} min cut rules.",
              layer->getName(),
+             is_below,
              tech_layer.dbuToMicron(width),
              min_rules_use == nullptr ? 0 : min_rules_use->size());
 
@@ -1505,17 +1510,19 @@ bool ViaGenerator::checkMinCuts(odb::dbTechLayer* layer, int width) const
   for (const auto& min_cut_rule : *min_rules_use) {
     const bool pass = min_cut_rule.cuts <= total_cuts;
 
-    debugPrint(
-        logger_,
-        utl::PDN,
-        "MinCut",
-        2,
-        "Rule width {:.4f} above ({}) or below ({}) requires {} vias: {}.",
-        tech_layer.dbuToMicron(min_cut_rule.width),
-        min_cut_rule.above,
-        min_cut_rule.below,
-        min_cut_rule.cuts,
-        pass);
+    debugPrint(logger_,
+               utl::PDN,
+               "MinCut",
+               2,
+               "Rule width {:.4f} above ({}) or below ({}) requires {} vias, "
+               "has {} vias {}: {}.",
+               tech_layer.dbuToMicron(min_cut_rule.width),
+               min_cut_rule.above,
+               min_cut_rule.below,
+               min_cut_rule.cuts,
+               total_cuts,
+               is_below ? "below" : "above",
+               pass);
 
     is_valid |= pass;
   }

src/pdn/src/via.h

@@ -382,7 +382,8 @@ class DbGenerateDummyVia : public DbVia
                      const odb::Rect& shape,
                      odb::dbTechLayer* bottom,
                      odb::dbTechLayer* top,
-                     bool add_report);
+                     bool add_report,
+                     const std::string& reason);
 
   ViaLayerShape generate(odb::dbBlock* block,
                          odb::dbSWire* wire,
@@ -400,6 +401,7 @@ class DbGenerateDummyVia : public DbVia
   const odb::Rect shape_;
   odb::dbTechLayer* bottom_;
   odb::dbTechLayer* top_;
+  std::string reason_;
 };
 
 // Class to build a generate via, either as a single group or as an array