safegaurd against fake newbests and whatnot

RayDeeUx · RayDeeUx · commit 1a8f0a5a35f5 · 2025-09-17T21:09:10.000-04:00
diff --git a/src/PlayLayer.cpp b/src/PlayLayer.cpp
@@ -151,6 +151,7 @@ class $modify(MyPlayLayer, PlayLayer) {
 	}
 	void showNewBest(bool newReward, int orbs, int diamonds, bool demonKey, bool noRetry, bool noTitle) {
 		PlayLayer::showNewBest(newReward, orbs, diamonds, demonKey, noRetry, noTitle);
+		if (!getModBool("enabled") || !m_player1->m_isDead || this->m_isPracticeMode || this->m_isTestMode) return;
 		log::info("isNewBestFloat: {}", MyPlayLayer::isNewBestFloat(this));
 		log::info("manager->hasPRNTSCRN: {}", manager->hasPRNTSCRN);
 		if (!manager->hasPRNTSCRN || !MyPlayLayer::isNewBestFloat(this) || !getModBool("screenshotOnDeath")) return;

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,7 @@ class $modify(MyPlayLayer, PlayLayer) {`
`151`	`151`	`}`
`152`	`152`	`void showNewBest(bool newReward, int orbs, int diamonds, bool demonKey, bool noRetry, bool noTitle) {`
`153`	`153`	`PlayLayer::showNewBest(newReward, orbs, diamonds, demonKey, noRetry, noTitle);`
	`154`	`+ if (!getModBool("enabled") \|\| !m_player1->m_isDead \|\| this->m_isPracticeMode \|\| this->m_isTestMode) return;`
`154`	`155`	`log::info("isNewBestFloat: {}", MyPlayLayer::isNewBestFloat(this));`
`155`	`156`	`log::info("manager->hasPRNTSCRN: {}", manager->hasPRNTSCRN);`
`156`	`157`	`if (!manager->hasPRNTSCRN \|\| !MyPlayLayer::isNewBestFloat(this) \|\| !getModBool("screenshotOnDeath")) return;`