@@ -473,7 +473,7 @@ void Utils::popualteSongToSongDataMap() {
473473 std::vector<std::string> tempKeys = {};
474474 std::error_code ec, ed;
475475
476- for (const std::string_view song : songManager.getSongs ()) {
476+ for (const std::string& song : songManager.getSongs ()) {
477477 SongType songType = SongType::Regular;
478478 if (std::ranges::find (blacklist.begin (), blacklist.end (), song) != blacklist.end ()) songType = SongType::Blacklisted;
479479 else if (std::ranges::find (favorites.begin (), favorites.end (), song) != favorites.end ()) songType = SongType::Favorited;
@@ -484,7 +484,7 @@ void Utils::popualteSongToSongDataMap() {
484484 std::filesystem::file_time_type fileTime = std::filesystem::last_write_time (theirPath, ed);
485485
486486 SongData songData = {
487- .actualFilePath = std::string ( song) ,
487+ .actualFilePath = song,
488488 .fileExtension = Utils::toNormalizedString (theirPath.extension ()),
489489 .fileName = Utils::toNormalizedString (theirPath.filename ()),
490490 .type = songType, .songFileSize = ec ? std::numeric_limits<std::uintmax_t >::max () : fileSize,
@@ -644,11 +644,11 @@ std::string Utils::toNormalizedString(const std::filesystem::path& path) {
644644 return geode::utils::string::pathToString (path);
645645}
646646
647- std::filesystem::path Utils::toProblematicString (const std::string_view path) {
647+ std::filesystem::path Utils::toProblematicString (const std::string& path) {
648648 #ifdef GEODE_IS_WINDOWS
649649 /* TODO FOR GEODE V5: SWAP COMMENTED LINES */
650- // return std::filesystem::path(geode::utils::string::utf8ToWide(std::string( path) ).unwrapOr(""));
651- return std::filesystem::path (geode::utils::string::utf8ToWide (std::string ( path) ));
650+ // return std::filesystem::path(geode::utils::string::utf8ToWide(path).unwrapOr(""));
651+ return std::filesystem::path (geode::utils::string::utf8ToWide (path));
652652 #else
653653 return std::filesystem::path (path);
654654 #endif
0 commit comments