whoops!

Author: RayDeeUx

changelog.md

@@ -6,6 +6,7 @@
   - You can also adjust how many milliseconds to increment/decrement by in the mod settings.
   - [Better Touch Prio](mod:alk.better-touch-prio) is <cl>requ</c><cj>ired</c> for this feature.
 - <co>Fixed</c> an issue where menu loop positions wouldn't be restored when leaving a level whose most recently played song was also the most recently selected menu loop.
+- <co>Fixed</c> several UI-related issues related to setting/unsetting a Song Override.
 ## v1.11.3, v1.11.4, and v1.11.5
 *<c-aaaaaa>Friendly reminder that</c> <cl>some</c> <cj>features</c> <c-aaaaaa>of this mod (including features related to bugfixes in this update) require [Better Touch Prio](mod:alk.better-touch-prio) to be installed. These decisions are still here to stay.</c>*
 - Fix massive oversights.

src/GameManager.cpp

@@ -18,45 +18,6 @@ class $modify(MenuLoopGMHook, GameManager) {
 		const geode::Mod* colon = songManager.getColonMenuLoopStartTime();
 		if (colon && colon->getSettingValue<bool>("enable")) return;
 		if (!songManager.getShouldRestoreMenuLoopPoint()) return;
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("songManager.getPauseSongPositionTracking(): {}", songManager.getPauseSongPositionTracking());
-		log::info("oldTrack: {}", oldTrack);
-		log::info("oldTrack: {}", oldTrack);
-		log::info("oldTrack: {}", oldTrack);
-		log::info("oldTrack: {}", oldTrack);
-		log::info("oldTrack: {}", oldTrack);
-		log::info("fmod->getActiveMusic(0): {}", fmod->getActiveMusic(0));
-		log::info("fmod->getActiveMusic(0): {}", fmod->getActiveMusic(0));
-		log::info("fmod->getActiveMusic(0): {}", fmod->getActiveMusic(0));
-		log::info("fmod->getActiveMusic(0): {}", fmod->getActiveMusic(0));
-		log::info("fmod->getActiveMusic(0): {}", fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("oldTrack == fmod->getActiveMusic(0): {}", oldTrack == fmod->getActiveMusic(0));
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
-		log::info("songManager.getLastMenuLoopPosition(): {}", songManager.getLastMenuLoopPosition());
 		if (oldTrack == fmod->getActiveMusic(0) && !songManager.getPauseSongPositionTracking()) return; // NOTE: THIS LINE CAN CAUSE ISSUES WHEN MENU LOOP AND LEVEL'S MOST RECENTLY PLAYED SONG ARE THE SAME
 		songManager.restoreLastMenuLoopPosition();
 		songManager.setShouldRestoreMenuLoopPoint(false);