fix misconceptions

Author: RayDeeUx

src/Utils.cpp

@@ -480,13 +480,13 @@ void Utils::popualteSongToSongDataMap() {
 		const std::filesystem::path& theirPath = Utils::toProblematicString(song);
 		SongData songData = {
 			.actualFilePath = std::string(song),
-			.fileExtension = theirPath.extension(),
-			.fileName = theirPath.filename(),
-			.displayName = theirPath.stem(),
+			.fileExtension = Utils::toNormalizedString(theirPath.extension()),
+			.fileName = Utils::toNormalizedString(theirPath.filename()),
 			.type = songType,
 			.isFromConfigOrAltDir = Utils::isFromConfigOrAlternateDir(theirPath.parent_path()),
 			.isEmpty = false
 		};
+		songData.displayName = Utils::toNormalizedString(SongListLayer::generateDisplayName(songData)),
 
 		songToSongData.emplace(theirPath, songData);
 		tempKeys.push_back(theirPath);

src/ui/SongListLayer.cpp

@@ -46,6 +46,8 @@ void SongListLayer::addSongsToScrollLayer(geode::ScrollLayer* scrollLayer, SongM
 	const std::vector<std::string>& songsVector = songManager.getSongs();
 	float desiredContentHeight = SEARCH_BAR_ENABLED ? 36.f : 0.f; // always start with the height of the blank song cell, which is guaranteed to be 36.f units
 
+	const SongToSongData& songToSongData = songManager.getSongToSongDataEntries();
+
 	for (const std::string& song : songsVector) {
 		if (std::ranges::find(alreadyAdded.begin(), alreadyAdded.end(), song) != alreadyAdded.end()) continue;
 
@@ -55,19 +57,27 @@ void SongListLayer::addSongsToScrollLayer(geode::ScrollLayer* scrollLayer, SongM
 
 		if (songListFavoritesOnlyMode && songType != SongType::Favorited) continue;
 
+		SongData songData {};
+		bool songDataFromTheMap = false;
 		const std::filesystem::path& songFilePath = Utils::toProblematicString(song);
-		SongData songData = {
-			.actualFilePath = Utils::toNormalizedString(songFilePath),
-			.fileExtension = Utils::toNormalizedString(songFilePath.extension()),
-			.fileName = Utils::toNormalizedString(songFilePath.filename()),
-			.type = songType,
-			.isFromConfigOrAltDir = Utils::isFromConfigOrAlternateDir(songFilePath.parent_path()),
-			.isEmpty = false
-		};
+		auto songDataIterator = songToSongData.find(songFilePath);
+		if (songDataIterator != songToSongData.end()) {
+			songData = songDataIterator->second;
+			songDataFromTheMap = true;
+		} else {
+			songData = {
+				.actualFilePath = Utils::toNormalizedString(songFilePath),
+				.fileExtension = Utils::toNormalizedString(songFilePath.extension()),
+				.fileName = Utils::toNormalizedString(songFilePath.filename()),
+				.type = songType,
+				.isFromConfigOrAltDir = Utils::isFromConfigOrAlternateDir(songFilePath.parent_path()),
+				.isEmpty = false
+			};
+		}
 
 		songData.displayName = SongListLayer::generateDisplayName(songData);
 
-		if (SONG_SORTING_ENABLED && SAVED("songListSortSongLength")) songData.songLength = SongListLayer::getLength(songData.actualFilePath, reverse);
+		if (SONG_SORTING_ENABLED && SAVED("songListSortSongLength") && !songDataFromTheMap) songData.songLength = SongListLayer::getLength(songData.actualFilePath, reverse);
 
 		if (SEARCH_BAR_ENABLED && !queryString.empty()) {
 			const bool contains = geode::utils::string::contains(geode::utils::string::toLower(songData.displayName), geode::utils::string::toLower(queryString));