Skip to content

Commit 05530fb

Browse files
committed
Converted if-else for etai_over_etat to ternary command
1 parent 16e9f06 commit 05530fb

File tree

4 files changed

+5
-30
lines changed

4 files changed

+5
-30
lines changed

books/RayTracingInOneWeekend.html

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2124,12 +2124,7 @@
21242124
const ray& r_in, const hit_record& rec, vec3& attenuation, ray& scattered
21252125
) const {
21262126
attenuation = vec3(1.0, 1.0, 1.0);
2127-
double etai_over_etat;
2128-
if (rec.front_face) {
2129-
etai_over_etat = 1.0 / ref_idx;
2130-
} else {
2131-
etai_over_etat = ref_idx;
2132-
}
2127+
double etai_over_etat = (rec.front_face) ? (1.0 / ref_idx) : (ref_idx);
21332128

21342129
vec3 unit_direction = unit_vector(r_in.direction());
21352130
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
@@ -2195,12 +2190,7 @@
21952190
const ray& r_in, const hit_record& rec, vec3& attenuation, ray& scattered
21962191
) const {
21972192
attenuation = vec3(1.0, 1.0, 1.0);
2198-
double etai_over_etat;
2199-
if (rec.front_face) {
2200-
etai_over_etat = 1.0 / ref_idx;
2201-
} else {
2202-
etai_over_etat = ref_idx;
2203-
}
2193+
double etai_over_etat = (rec.front_face) ? (1.0 / ref_idx) : (ref_idx);
22042194

22052195
vec3 unit_direction = unit_vector(r_in.direction());
22062196
double cos_theta = ffmin(dot(-unit_direction, rec.normal), 1.0);

src/InOneWeekend/material.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,7 @@ class dielectric : public material {
4040
const ray& r_in, const hit_record& rec, vec3& attenuation, ray& scattered
4141
) const {
4242
attenuation = vec3(1.0, 1.0, 1.0);
43-
double etai_over_etat;
44-
if (rec.front_face) {
45-
etai_over_etat = 1.0 / ref_idx;
46-
} else {
47-
etai_over_etat = ref_idx;
48-
}
43+
double etai_over_etat = (rec.front_face) ? (1.0 / ref_idx) : (ref_idx);
4944

5045
vec3 unit_direction = unit_vector(r_in.direction());
5146
double cos_theta = ffmin(dot(-unit_direction, rec.normal), 1.0);

src/TheNextWeek/material.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,7 @@ class dielectric : public material {
4343
const ray& r_in, const hit_record& rec, vec3& attenuation, ray& scattered
4444
) const {
4545
attenuation = vec3(1.0, 1.0, 1.0);
46-
double etai_over_etat;
47-
if (rec.front_face) {
48-
etai_over_etat = 1.0 / ref_idx;
49-
} else {
50-
etai_over_etat = ref_idx;
51-
}
46+
double etai_over_etat = (rec.front_face) ? (1.0 / ref_idx) : (ref_idx);
5247

5348
vec3 unit_direction = unit_vector(r_in.direction());
5449
double cos_theta = ffmin(dot(-unit_direction, rec.normal), 1.0);

src/TheRestOfYourLife/material.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,7 @@ class dielectric : public material {
6464
srec.is_specular = true;
6565
srec.pdf_ptr = 0;
6666
srec.attenuation = vec3(1.0, 1.0, 1.0);
67-
double etai_over_etat;
68-
if (rec.front_face) {
69-
etai_over_etat = 1.0 / ref_idx;
70-
} else {
71-
etai_over_etat = ref_idx;
72-
}
67+
double etai_over_etat = (rec.front_face) ? (1.0 / ref_idx) : (ref_idx);
7368

7469
vec3 unit_direction = unit_vector(r_in.direction());
7570
double cos_theta = ffmin(dot(-unit_direction, rec.normal), 1.0);

0 commit comments

Comments
 (0)