Skip to content

Commit 51eadff

Browse files
committed
Fix camera declaration, undefined vup variable
Resolves #686
1 parent e56b527 commit 51eadff

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Change Log -- Ray Tracing in One Weekend
55

66
### _In One Weekend_
77
- Fix: replace old anti-alias result image with before-and-after image (#679)
8+
- Fix: undefined `vup` variable in camera definition (#686)
89

910
### _The Next Week_
1011
- Delete: remove unused u,v,w variables in initial `perlin::noise()` function (#684)

books/RayTracingInOneWeekend.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2848,7 +2848,7 @@
28482848
And we can change field of view:
28492849

28502850
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
2851-
camera cam(point3(-2,2,1), point3(0,0,-1), vup, 20, aspect_ratio);
2851+
camera cam(point3(-2,2,1), point3(0,0,-1), vec3(0,1,0), 20, aspect_ratio);
28522852
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
28532853
[Listing [change-field-view]: <kbd>[main.cc]</kbd> Change field of view]
28542854

0 commit comments

Comments
 (0)