Skip to content

Commit 63825b5

Browse files
committed
Clean up ray constructors
Eliminate the defaulted time parameter originally present in the book (though not reflected in the source).
1 parent 69fe1ba commit 63825b5

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

books/RayTracingTheNextWeek.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@
7171

7272

7373
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
74-
ray(const point3& origin, const vec3& direction) : orig(origin), dir(direction), tm(0) {}
74+
ray(const point3& origin, const vec3& direction)
75+
: orig(origin), dir(direction), tm(0) {}
7576

7677
ray(const point3& origin, const vec3& direction, double time)
77-
: orig(origin), dir(direction), tm(time)
78-
{}
78+
: orig(origin), dir(direction), tm(time) {}
7979
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
8080

8181
point3 origin() const { return orig; }

src/TheNextWeek/ray.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@ class ray {
1818
public:
1919
ray() {}
2020

21-
ray(const point3& origin, const vec3& direction) : orig(origin), dir(direction), tm(0)
22-
{}
21+
ray(const point3& origin, const vec3& direction)
22+
: orig(origin), dir(direction), tm(0) {}
2323

2424
ray(const point3& origin, const vec3& direction, double time)
25-
: orig(origin), dir(direction), tm(time)
26-
{}
25+
: orig(origin), dir(direction), tm(time) {}
2726

2827
point3 origin() const { return orig; }
2928
vec3 direction() const { return dir; }

src/TheRestOfYourLife/ray.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,11 @@ class ray {
1818
public:
1919
ray() {}
2020

21-
ray(const point3& origin, const vec3& direction) : orig(origin), dir(direction), tm(0)
22-
{}
21+
ray(const point3& origin, const vec3& direction)
22+
: orig(origin), dir(direction), tm(0) {}
2323

2424
ray(const point3& origin, const vec3& direction, double time)
25-
: orig(origin), dir(direction), tm(time)
26-
{}
25+
: orig(origin), dir(direction), tm(time) {}
2726

2827
point3 origin() const { return orig; }
2928
vec3 direction() const { return dir; }

0 commit comments

Comments
 (0)