Skip to content

Commit 87eb416

Browse files
authored
Merge pull request #537 from RayTracing/fix-523
Fix camera initialization with explicit vup vector
2 parents 15d3367 + 238fa31 commit 87eb416

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Change Log -- Ray Tracing in One Weekend
44
# v3.1.1 (in progress)
55

66
### _In One Weekend_
7+
- Fix: Camera initialization with explicit up vector (#537)
78
- Change: The C++ `<random>` version of `random_double()` no longer depends on `<functional>`
89
header.
910
- Change: Refactored `random_scene()`. More named intermediate values, sync'ed with source.

books/RayTracingInOneWeekend.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2669,7 +2669,7 @@
26692669
This allows us to change the viewpoint:
26702670

26712671
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
2672-
camera cam(point3(-2,2,1), point3(0,0,-1), vup, 90, aspect_ratio);
2672+
camera cam(point3(-2,2,1), point3(0,0,-1), vec3(0,1,0), 90, aspect_ratio);
26732673
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
26742674
[Listing [scene-free-view]: <kbd>[main.cc]</kbd> Scene with alternate viewpoint]
26752675

0 commit comments

Comments
 (0)