Skip to content

Commit 89d6640

Browse files
committed
Add override specifier: texture subclasses
1 parent 1fe7af1 commit 89d6640

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

books/RayTracingTheNextWeek.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1063,7 +1063,7 @@
10631063
solid_color(double red, double green, double blue)
10641064
: solid_color(color(red,green,blue)) {}
10651065

1066-
virtual color value(double u, double v, const vec3& p) const {
1066+
virtual color value(double u, double v, const vec3& p) const override {
10671067
return color_value;
10681068
}
10691069

@@ -1245,7 +1245,7 @@
12451245
checker_texture(color c1, color c2)
12461246
: even(make_shared<solid_color>(c1)) , odd(make_shared<solid_color>(c2)) {}
12471247

1248-
virtual color value(double u, double v, const point3& p) const {
1248+
virtual color value(double u, double v, const point3& p) const override {
12491249
auto sines = sin(10*p.x())*sin(10*p.y())*sin(10*p.z());
12501250
if (sines < 0)
12511251
return odd->value(u, v, p);
@@ -1486,7 +1486,7 @@
14861486
public:
14871487
noise_texture() {}
14881488

1489-
virtual color value(double u, double v, const point3& p) const {
1489+
virtual color value(double u, double v, const point3& p) const override {
14901490
return color(1,1,1) * noise.noise(p);
14911491
}
14921492

@@ -1666,7 +1666,7 @@
16661666
noise_texture(double sc) : scale(sc) {}
16671667
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
16681668

1669-
virtual color value(double u, double v, const point3& p) const {
1669+
virtual color value(double u, double v, const point3& p) const override {
16701670
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
16711671
return color(1,1,1) * noise.noise(scale * p);
16721672
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
@@ -1843,7 +1843,7 @@
18431843
noise_texture() {}
18441844
noise_texture(double sc) : scale(sc) {}
18451845

1846-
virtual color value(double u, double v, const point3& p) const {
1846+
virtual color value(double u, double v, const point3& p) const override {
18471847
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
18481848
return color(1,1,1) * 0.5 * (1.0 + noise.noise(scale * p));
18491849
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
@@ -1904,7 +1904,7 @@
19041904
noise_texture() {}
19051905
noise_texture(double sc) : scale(sc) {}
19061906

1907-
virtual color value(double u, double v, const point3& p) const {
1907+
virtual color value(double u, double v, const point3& p) const override {
19081908
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
19091909
return color(1,1,1) * noise.turb(scale * p);
19101910
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
@@ -1941,7 +1941,7 @@
19411941
noise_texture() {}
19421942
noise_texture(double sc) : scale(sc) {}
19431943

1944-
virtual color value(double u, double v, const point3& p) const {
1944+
virtual color value(double u, double v, const point3& p) const override {
19451945
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
19461946
return color(1,1,1) * 0.5 * (1 + sin(scale*p.z() + 10*noise.turb(p)));
19471947
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
@@ -2025,7 +2025,7 @@
20252025
delete data;
20262026
}
20272027

2028-
virtual color value(double u, double v, const vec3& p) const {
2028+
virtual color value(double u, double v, const vec3& p) const override {
20292029
// If we have no texture data, then return solid cyan as a debugging aid.
20302030
if (data == nullptr)
20312031
return color(0,1,1);

src/common/texture.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class solid_color : public texture {
3333
solid_color(double red, double green, double blue)
3434
: solid_color(color(red,green,blue)) {}
3535

36-
virtual color value(double u, double v, const vec3& p) const {
36+
virtual color value(double u, double v, const vec3& p) const override {
3737
return color_value;
3838
}
3939

@@ -52,7 +52,7 @@ class checker_texture : public texture {
5252
checker_texture(color c1, color c2)
5353
: even(make_shared<solid_color>(c1)) , odd(make_shared<solid_color>(c2)) {}
5454

55-
virtual color value(double u, double v, const vec3& p) const {
55+
virtual color value(double u, double v, const vec3& p) const override {
5656
auto sines = sin(10*p.x())*sin(10*p.y())*sin(10*p.z());
5757
if (sines < 0)
5858
return odd->value(u, v, p);
@@ -71,7 +71,7 @@ class noise_texture : public texture {
7171
noise_texture() {}
7272
noise_texture(double sc) : scale(sc) {}
7373

74-
virtual color value(double u, double v, const vec3& p) const {
74+
virtual color value(double u, double v, const vec3& p) const override {
7575
// return color(1,1,1)*0.5*(1 + noise.turb(scale * p));
7676
// return color(1,1,1)*noise.turb(scale * p);
7777
return color(1,1,1)*0.5*(1 + sin(scale*p.z() + 10*noise.turb(p)));
@@ -108,7 +108,7 @@ class image_texture : public texture {
108108
delete data;
109109
}
110110

111-
virtual color value(double u, double v, const vec3& p) const {
111+
virtual color value(double u, double v, const vec3& p) const override {
112112
// If we have no texture data, then return solid cyan as a debugging aid.
113113
if (data == nullptr)
114114
return color(0,1,1);

0 commit comments

Comments
 (0)