Skip to content

Commit c0a24a9

Browse files
trevordblackhollasch
authored andcommitted
Least mental model breaking way to add a color scattered variable
1 parent 7952f43 commit c0a24a9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

books/RayTracingTheRestOfYourLife.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1690,10 +1690,10 @@
16901690
double scattering_pdf = rec.mat->scattering_pdf(r, rec, scattered);
16911691
double pdf = scattering_pdf;
16921692

1693-
color scattered =
1693+
color scattered_color =
16941694
(attenuation * scattering_pdf * ray_color(scattered, depth-1)) / pdf;
16951695

1696-
return emitted + scattered;
1696+
return emitted + scattered_color;
16971697
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
16981698
}
16991699
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -1744,11 +1744,11 @@
17441744
double pdf = 1 / (2*pi);
17451745
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
17461746

1747-
color scattered =
1747+
color scattered_color =
17481748
(attenuation * scattering_pdf * ray_color(scattered, depth-1)) / pdf;
17491749

17501750

1751-
return emitted + scattered;
1751+
return emitted + scattered_color;
17521752
}
17531753
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
17541754
[Listing [ray-color-uniform]: <kbd>[scene.h]</kbd>

src/TheRestOfYourLife/scene.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,11 @@ class scene {
7979
ray scattered = ray(rec.p, p.generate(), r.time());
8080
auto pdf_val = p.value(scattered.direction());
8181

82-
color scattered = (srec.attenuation
82+
color scattered_color = (srec.attenuation
8383
* rec.mat->scattering_pdf(r, rec, scattered)
8484
* ray_color(scattered, depth-1)) / pdf_val;
8585

86-
return emitted + scattered;
86+
return emitted + scattered_color;
8787
}
8888
};
8989

0 commit comments

Comments
 (0)