Skip to content

Commit ed310f5

Browse files
ronaldfwhollasch
authored andcommitted
Sync changes in cross product computation to all vec3.h src files
Addresses: #69
1 parent e5236bf commit ed310f5

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/TheNextWeek/vec3.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ inline float dot(const vec3 &v1, const vec3 &v2) {
9898
}
9999

100100
inline vec3 cross(const vec3 &v1, const vec3 &v2) {
101-
return vec3( (v1.e[1]*v2.e[2] - v1.e[2]*v2.e[1]),
102-
(-(v1.e[0]*v2.e[2] - v1.e[2]*v2.e[0])),
103-
(v1.e[0]*v2.e[1] - v1.e[1]*v2.e[0]));
101+
return vec3(v1.e[1]*v2.e[2] - v1.e[2]*v2.e[1],
102+
v1.e[2]*v2.e[0] - v1.e[0]*v2.e[2],
103+
v1.e[0]*v2.e[1] - v1.e[1]*v2.e[0]);
104104
}
105105

106106

src/TheRestOfYourLife/vec3.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ inline float dot(const vec3 &v1, const vec3 &v2) {
9999
}
100100

101101
inline vec3 cross(const vec3 &v1, const vec3 &v2) {
102-
return vec3( (v1.e[1]*v2.e[2] - v1.e[2]*v2.e[1]),
103-
(-(v1.e[0]*v2.e[2] - v1.e[2]*v2.e[0])),
104-
(v1.e[0]*v2.e[1] - v1.e[1]*v2.e[0]));
102+
return vec3(v1.e[1]*v2.e[2] - v1.e[2]*v2.e[1],
103+
v1.e[2]*v2.e[0] - v1.e[0]*v2.e[2],
104+
v1.e[0]*v2.e[1] - v1.e[1]*v2.e[0]);
105105
}
106106

107-
108107
inline vec3& vec3::operator+=(const vec3 &v){
109108
e[0] += v.e[0];
110109
e[1] += v.e[1];

0 commit comments

Comments
 (0)