disable throttle for records multi selection

Author: Razeeman

core/src/main/java/com/example/util/simpletimetracker/core/base/BaseBottomSheetFragment.kt

@@ -9,6 +9,7 @@ import androidx.core.view.WindowCompat
 import androidx.core.view.updatePadding
 import androidx.fragment.app.DialogFragment
 import androidx.lifecycle.LiveData
+import androidx.lifecycle.lifecycleScope
 import androidx.viewbinding.ViewBinding
 import com.example.util.simpletimetracker.core.R
 import com.example.util.simpletimetracker.core.utils.applyNavBarInsets
@@ -17,6 +18,7 @@ import com.example.util.simpletimetracker.core.utils.getStatusBarInsets
 import com.example.util.simpletimetracker.navigation.Router
 import com.google.android.material.bottomsheet.BottomSheetDialog
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
+import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Job
 import javax.inject.Inject
 
@@ -30,6 +32,10 @@ abstract class BaseBottomSheetFragment<T : ViewBinding> : BottomSheetDialogFragm
     protected val binding: T get() = _binding!!
     private var _binding: T? = null
 
+    override fun getScope(): CoroutineScope {
+        return lifecycleScope
+    }
+
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setStyle(DialogFragment.STYLE_NORMAL, R.style.BottomSheetDialog)

core/src/main/java/com/example/util/simpletimetracker/core/base/BaseFragment.kt

@@ -8,9 +8,11 @@ import android.view.ViewGroup
 import android.view.ViewTreeObserver.OnPreDrawListener
 import androidx.fragment.app.Fragment
 import androidx.lifecycle.LiveData
+import androidx.lifecycle.lifecycleScope
 import androidx.viewbinding.ViewBinding
 import com.example.util.simpletimetracker.core.utils.InsetConfiguration
 import com.example.util.simpletimetracker.core.utils.applyNavBarInsets
+import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Job
 
 abstract class BaseFragment<T : ViewBinding> : Fragment(), Throttler {
@@ -23,6 +25,10 @@ abstract class BaseFragment<T : ViewBinding> : Fragment(), Throttler {
     private var preDrawListeners: MutableList<OnPreDrawListener> = mutableListOf()
     private var initialized: Boolean = false
 
+    override fun getScope(): CoroutineScope {
+        return lifecycleScope
+    }
+
     override fun onCreateView(
         inflater: LayoutInflater,
         container: ViewGroup?,

core/src/main/java/com/example/util/simpletimetracker/core/base/BaseViewModel.kt

@@ -3,8 +3,11 @@ package com.example.util.simpletimetracker.core.base
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
 import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Job
 
-abstract class BaseViewModel : ViewModel(), ScopeHolder {
+abstract class BaseViewModel : ViewModel(), ScopeHolder, Throttler {
+
+    override var throttleJob: Job? = null
 
     override fun getScope(): CoroutineScope {
         return viewModelScope

core/src/main/java/com/example/util/simpletimetracker/core/base/Throttler.kt

@@ -1,12 +1,10 @@
 package com.example.util.simpletimetracker.core.base
 
-import androidx.lifecycle.LifecycleOwner
-import androidx.lifecycle.lifecycleScope
 import kotlinx.coroutines.Job
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
-interface Throttler : LifecycleOwner {
+interface Throttler : ScopeHolder {
 
     var throttleJob: Job?
 
@@ -30,7 +28,7 @@ interface Throttler : LifecycleOwner {
 
     private fun throttler(block: () -> Unit) {
         if (throttleJob?.isCompleted != false) {
-            throttleJob = lifecycleScope.launch {
+            throttleJob = getScope().launch {
                 block()
                 delay(THROTTLE_PERIOD_MS)
             }

features/feature_dialogs/src/main/java/com/example/util/simpletimetracker/feature_dialogs/recordQuickActions/viewModel/RecordQuickActionsViewModel.kt

@@ -266,7 +266,6 @@ class RecordQuickActionsViewModel @Inject constructor(
 
     private suspend fun onMultiselect() {
         // TODO MULTI cancel on tab change?
-        // TODO MULTI disable throttle record click in multiselect
         if (recordsContainerMultiselectInteractor.isEnabled) {
             recordsContainerMultiselectInteractor.disable()
         } else {

features/feature_records/src/main/java/com/example/util/simpletimetracker/feature_records/view/RecordsFragment.kt

@@ -84,8 +84,8 @@ class RecordsFragment :
     }
 
     override fun initUx() {
-        binding.viewRecordsCalendar.root.setClickListener(throttle(viewModel::onCalendarClick))
-        binding.viewRecordsCalendar.root.setLongClickListener(throttle(viewModel::onCalendarLongClick))
+        binding.viewRecordsCalendar.root.setClickListener(viewModel::onCalendarClick)
+        binding.viewRecordsCalendar.root.setLongClickListener(viewModel::onCalendarLongClick)
     }
 
     override fun initViewModel() {
@@ -216,12 +216,12 @@ class RecordsFragment :
         return BaseRecyclerAdapter(
             createRunningRecordAdapterDelegate(
                 transitionNamePrefix = TransitionNames.RUNNING_RECORD_FROM_RECORDS,
-                onItemClick = throttle(viewModel::onRunningRecordClick),
-                onItemLongClick = throttle(viewModel::onRunningRecordLongClick),
+                onItemClick = viewModel::onRunningRecordClick,
+                onItemLongClick = viewModel::onRunningRecordLongClick,
             ),
             createRecordAdapterDelegate(
-                onItemClick = throttle(viewModel::onRecordClick),
-                onItemLongClick = throttle(viewModel::onRecordLongClick),
+                onItemClick = viewModel::onRecordClick,
+                onItemLongClick = viewModel::onRecordLongClick,
             ),
             createRunningRecordSelectedAdapterDelegate(
                 onItemClick = viewModel::onRunningRecordClick,

features/feature_records/src/main/java/com/example/util/simpletimetracker/feature_records/viewModel/RecordsViewModel.kt

@@ -2,8 +2,8 @@ package com.example.util.simpletimetracker.feature_records.viewModel
 
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
-import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
+import com.example.util.simpletimetracker.core.base.BaseViewModel
 import com.example.util.simpletimetracker.core.base.SingleLiveEvent
 import com.example.util.simpletimetracker.core.extension.set
 import com.example.util.simpletimetracker.core.extension.toParams
@@ -58,7 +58,7 @@ class RecordsViewModel @Inject constructor(
     private val getChangeRecordNavigationParamsInteractor: GetChangeRecordNavigationParamsInteractor,
     private val recordsContainerMultiselectInteractor: RecordsContainerMultiselectInteractor,
     private val themeChangedInteractor: ThemeChangedInteractor,
-) : ViewModel() {
+) : BaseViewModel() {
 
     var extra: RecordsExtra? = null
 
@@ -112,10 +112,12 @@ class RecordsViewModel @Inject constructor(
             showSeconds = showSeconds,
             sharedElements = sharedElements,
         )
-        router.navigate(
-            data = ChangeRunningRecordFromMainParams(params),
-            sharedElements = sharedElements?.let(::mapOf).orEmpty(),
-        )
+        throttle {
+            router.navigate(
+                data = ChangeRunningRecordFromMainParams(params),
+                sharedElements = sharedElements?.let(::mapOf).orEmpty(),
+            )
+        }.invoke()
     }
 
     fun onRecordClick(
@@ -136,10 +138,12 @@ class RecordsViewModel @Inject constructor(
             showSeconds = showSeconds,
             sharedElements = sharedElements,
         )
-        router.navigate(
-            data = ChangeRecordFromMainParams(params),
-            sharedElements = sharedElements?.let(::mapOf).orEmpty(),
-        )
+        throttle {
+            router.navigate(
+                data = ChangeRecordFromMainParams(params),
+                sharedElements = sharedElements?.let(::mapOf).orEmpty(),
+            )
+        }.invoke()
     }
 
     @Suppress("UNUSED_PARAMETER")
@@ -155,7 +159,7 @@ class RecordsViewModel @Inject constructor(
                 return
             }
         }
-        RecordQuickActionsParams(
+        val navParams = RecordQuickActionsParams(
             type = RecordQuickActionsParams.Type.RecordRunning(
                 id = item.id,
             ),
@@ -164,7 +168,10 @@ class RecordsViewModel @Inject constructor(
                 iconId = item.iconId.toParams(),
                 color = item.color,
             ),
-        ).let(router::navigate)
+        )
+        throttle {
+            router.navigate(navParams)
+        }.invoke()
     }
 
     @Suppress("UNUSED_PARAMETER")
@@ -195,14 +202,17 @@ class RecordsViewModel @Inject constructor(
                 timeEnded = item.timeEndedTimestamp,
             )
         }
-        RecordQuickActionsParams(
+        val navParams = RecordQuickActionsParams(
             type = type,
             preview = RecordQuickActionsParams.Preview(
                 name = item.name,
                 iconId = item.iconId.toParams(),
                 color = item.color,
             ),
-        ).let(router::navigate)
+        )
+        throttle {
+            router.navigate(navParams)
+        }.invoke()
     }
 
     fun onVisible() {