shift comment selection to top on keyboard opened

Author: Razeeman

app/src/androidTest/java/com/example/util/simpletimetracker/ChangeRecordTest.kt

@@ -8,7 +8,6 @@ import androidx.test.espresso.matcher.ViewMatchers.hasDescendant
 import androidx.test.espresso.matcher.ViewMatchers.isCompletelyDisplayed
 import androidx.test.espresso.matcher.ViewMatchers.withClassName
 import androidx.test.espresso.matcher.ViewMatchers.withId
-import androidx.test.espresso.matcher.ViewMatchers.withSubstring
 import androidx.test.espresso.matcher.ViewMatchers.withText
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.example.util.simpletimetracker.feature_dialogs.dateTime.CustomDatePicker

app/src/androidTest/java/com/example/util/simpletimetracker/RetroactiveTrackingModeTest.kt

@@ -213,6 +213,5 @@ class RetroactiveTrackingModeTest : BaseUiTest() {
                 hasDescendant(withSubstring(text)),
             ),
         )
-
     }
 }

core/src/main/java/com/example/util/simpletimetracker/core/extension/BottomSheetDialogExtensions.kt

@@ -21,12 +21,16 @@ fun BottomSheetDialogFragment.setSkipCollapsed() {
     }
 }
 
-fun BottomSheetDialogFragment.setFullScreen() {
+fun BottomSheetDialogFragment.setFullScreen(isFullScreen: Boolean = true) {
     // Dialog parent is R.id.design_bottom_sheet from android material.
     // It's a wrapper created around dialog to set bottom sheet behavior. By default it's created
     // with wrap_content height, so we replace it here.
     (view?.parent as? FrameLayout)?.apply {
-        layoutParams?.height = CoordinatorLayout.LayoutParams.MATCH_PARENT
+        layoutParams?.height = if (isFullScreen) {
+            CoordinatorLayout.LayoutParams.MATCH_PARENT
+        } else {
+            CoordinatorLayout.LayoutParams.WRAP_CONTENT
+        }
         requestLayout() // TODO necessary?
     }
 }

core/src/main/java/com/example/util/simpletimetracker/core/manager/KeyboardVisibilityManager.kt

@@ -0,0 +1,31 @@
+package com.example.util.simpletimetracker.core.manager
+
+import androidx.core.view.WindowInsetsCompat
+import com.example.util.simpletimetracker.core.utils.isKeyboardInsetsVisible
+
+object KeyboardVisibilityManager {
+    private var isKeyboardVisible: Boolean = false
+    private var observers: MutableMap<Any, Observer> = mutableMapOf()
+
+    fun onInsetsChanged(insets: WindowInsetsCompat) {
+        val isVisible = insets.isKeyboardInsetsVisible()
+        if (isVisible != isKeyboardVisible) {
+            isKeyboardVisible = isVisible
+            observers.values.forEach { observer ->
+                observer.onKeyboardVisibilityChanged(isVisible)
+            }
+        }
+    }
+
+    fun addObserver(tag: Any, observer: Observer) {
+        observers[tag] = observer
+    }
+
+    fun removeObserver(tag: Any) {
+        observers.remove(tag)
+    }
+
+    fun interface Observer {
+        fun onKeyboardVisibilityChanged(isVisible: Boolean)
+    }
+}

core/src/main/java/com/example/util/simpletimetracker/core/utils/InsetUtils.kt

@@ -5,10 +5,13 @@ import androidx.core.graphics.Insets
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
 import androidx.core.view.updatePadding
+import com.example.util.simpletimetracker.core.manager.KeyboardVisibilityManager
 
 // Can update padding or margin, which would be more appropriate.
 fun View.doOnApplyWindowInsetsListener(block: View.(WindowInsetsCompat) -> Unit) {
     ViewCompat.setOnApplyWindowInsetsListener(this) { _, windowInsets ->
+        // All setOnApplyWindowInsetsListener listeners should call Keyboard manager.
+        KeyboardVisibilityManager.onInsetsChanged(windowInsets)
         block(windowInsets)
         windowInsets
     }
@@ -41,6 +44,11 @@ fun WindowInsetsCompat.getSystemBarInsets(): Insets {
     return getInsets(WindowInsetsCompat.Type.systemBars())
 }
 
+// Need windowSoftInputMode="adjustResize" on activity in order to work on api < 30.
+fun WindowInsetsCompat.isKeyboardInsetsVisible(): Boolean {
+    return isVisible(WindowInsetsCompat.Type.ime())
+}
+
 sealed interface InsetConfiguration {
     object DoNotApply : InsetConfiguration
     data class ApplyToView(val view: () -> View) : InsetConfiguration

features/feature_dialogs/src/main/java/com/example/util/simpletimetracker/feature_dialogs/recordTagSelection/RecordTagSelectionDialogFragment.kt

@@ -7,7 +7,9 @@ import android.view.ViewGroup
 import androidx.fragment.app.commit
 import com.example.util.simpletimetracker.core.base.BaseBottomSheetFragment
 import com.example.util.simpletimetracker.core.dialog.OnTagSelectedListener
+import com.example.util.simpletimetracker.core.extension.setFullScreen
 import com.example.util.simpletimetracker.core.extension.setSkipCollapsed
+import com.example.util.simpletimetracker.core.manager.KeyboardVisibilityManager
 import com.example.util.simpletimetracker.core.utils.fragmentArgumentDelegate
 import com.example.util.simpletimetracker.feature_dialogs.R
 import com.example.util.simpletimetracker.navigation.ScreenFactory
@@ -47,6 +49,19 @@ class RecordTagSelectionDialogFragment :
         }
     }
 
+    override fun initUx() {
+        KeyboardVisibilityManager.addObserver(this@RecordTagSelectionDialogFragment, ::onKeyboardVisible)
+    }
+
+    override fun onDestroy() {
+        KeyboardVisibilityManager.removeObserver(this@RecordTagSelectionDialogFragment)
+        super.onDestroy()
+    }
+
+    private fun onKeyboardVisible(isVisible: Boolean) {
+        setFullScreen(isFullScreen = isVisible)
+    }
+
     companion object {
         private const val ARGS_PARAMS = "args_params"
 

features/feature_tag_selection/src/main/java/com/example/util/simpletimetracker/feature_tag_selection/view/RecordTagSelectionFragment.kt

@@ -4,10 +4,13 @@ import android.content.Context
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.ViewGroup
+import android.view.WindowManager
+import androidx.constraintlayout.widget.ConstraintLayout
 import androidx.fragment.app.viewModels
 import com.example.util.simpletimetracker.core.base.BaseFragment
 import com.example.util.simpletimetracker.core.dialog.OnTagSelectedListener
 import com.example.util.simpletimetracker.core.extension.findListeners
+import com.example.util.simpletimetracker.core.manager.KeyboardVisibilityManager
 import com.example.util.simpletimetracker.core.utils.InsetConfiguration
 import com.example.util.simpletimetracker.core.utils.fragmentArgumentDelegate
 import com.example.util.simpletimetracker.feature_base_adapter.BaseRecyclerAdapter
@@ -23,6 +26,7 @@ import com.example.util.simpletimetracker.feature_base_adapter.loader.createLoad
 import com.example.util.simpletimetracker.feature_base_adapter.recordComment.createRecordCommentAdapterDelegate
 import com.example.util.simpletimetracker.feature_tag_selection.adapter.createRecordTagSelectionTextAdapterDelegate
 import com.example.util.simpletimetracker.feature_tag_selection.viewModel.RecordTagSelectionViewModel
+import com.example.util.simpletimetracker.feature_views.extension.safeUpdateLayoutParams
 import com.example.util.simpletimetracker.feature_views.extension.setOnClick
 import com.example.util.simpletimetracker.feature_views.extension.visible
 import com.example.util.simpletimetracker.navigation.params.screen.RecordTagSelectionParams
@@ -81,11 +85,13 @@ class RecordTagSelectionFragment : BaseFragment<Binding>() {
     }
 
     override fun initUx() = with(binding) {
+        KeyboardVisibilityManager.addObserver(this@RecordTagSelectionFragment, ::onKeyboardVisible)
         btnRecordTagSelectionSave.setOnClick(viewModel::onSaveClick)
     }
 
     override fun initViewModel(): Unit = with(viewModel) {
         extra = params
+        saveSoftInputMode()
         viewData.observe(adapter::replace)
         saveButtonVisibility.observe {
             binding.dividerTypesSelectionBottom.visible = it
@@ -94,10 +100,31 @@ class RecordTagSelectionFragment : BaseFragment<Binding>() {
         saveClicked.observe { onTagSelected() }
     }
 
+    override fun onDestroy() {
+        restoreSoftInputMode()
+        KeyboardVisibilityManager.removeObserver(this@RecordTagSelectionFragment)
+        super.onDestroy()
+    }
+
     private fun onTagSelected() {
         listeners.forEach { it.onTagSelected() }
     }
 
+    private fun onKeyboardVisible(isVisible: Boolean) {
+        binding.rvRecordTagSelectionList.safeUpdateLayoutParams<ConstraintLayout.LayoutParams> {
+            verticalBias = if (isVisible) 0.0f else 0.5f
+        }
+    }
+
+    private fun saveSoftInputMode() {
+        activity?.window?.attributes?.softInputMode?.let { viewModel.softInputMode = it }
+        activity?.window?.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE)
+    }
+
+    private fun restoreSoftInputMode() {
+        viewModel.softInputMode?.let { activity?.window?.setSoftInputMode(it) }
+    }
+
     companion object {
         private const val ARGS_PARAMS = "args_params"
 

features/feature_tag_selection/src/main/java/com/example/util/simpletimetracker/feature_tag_selection/viewModel/RecordTagSelectionViewModel.kt

@@ -7,8 +7,8 @@ import com.example.util.simpletimetracker.core.base.BaseViewModel
 import com.example.util.simpletimetracker.core.extension.lazySuspend
 import com.example.util.simpletimetracker.core.extension.set
 import com.example.util.simpletimetracker.domain.extension.addOrRemove
-import com.example.util.simpletimetracker.domain.record.interactor.AddRunningRecordMediator
 import com.example.util.simpletimetracker.domain.prefs.interactor.PrefsInteractor
+import com.example.util.simpletimetracker.domain.record.interactor.AddRunningRecordMediator
 import com.example.util.simpletimetracker.domain.recordTag.interactor.AddTagToTypeIfNotExistMediator
 import com.example.util.simpletimetracker.feature_base_adapter.ViewHolderType
 import com.example.util.simpletimetracker.feature_base_adapter.category.CategoryViewData
@@ -30,6 +30,7 @@ class RecordTagSelectionViewModel @Inject constructor(
 ) : BaseViewModel() {
 
     lateinit var extra: RecordTagSelectionParams
+    var softInputMode: Int? = null
 
     val viewData: LiveData<List<ViewHolderType>> by lazy {
         return@lazy MutableLiveData<List<ViewHolderType>>().let { initial ->

features/feature_tag_selection/src/main/res/layout/record_tag_selection_fragment.xml

@@ -12,7 +12,8 @@
         app:layout_constrainedHeight="true"
         app:layout_constraintBottom_toTopOf="@id/dividerTypesSelectionBottom"
         app:layout_constraintTop_toTopOf="parent"
-        tools:itemCount="15"
+        tools:itemCount="10"
+        tools:layout_constraintVertical_bias="0.5"
         tools:listitem="@layout/item_category_layout" />
 
     <View

features/feature_views/src/main/java/com/example/util/simpletimetracker/feature_views/extension/ViewExtensions.kt

@@ -207,4 +207,12 @@ fun View.setRounded(radiusDp: Int) {
         }
     }
     clipToOutline = true
+}
+
+inline fun <reified T : ViewGroup.LayoutParams> View.safeUpdateLayoutParams(
+    block: T.() -> Unit,
+) {
+    val params = layoutParams as? T ?: return
+    block(params)
+    layoutParams = params
 }