Refine conditional build (#410)

* Streamline and simplify configure and Makevars.in

* Add macos-13 to CI matrix for test on x86_64 macos without blp

* Remove a bashism in configure

* GNU make is a SystemRequirement (because of ifeq/endif)

* Roll micro version and date

* Cover 'yes/no' case fully from configure so no ifeq needed in make

* Rework in terms of an affirming -DHaveBlp and streamline code

Author: eddelbuettel

.github/workflows/ci.yaml

@@ -14,7 +14,8 @@ jobs:
     strategy:
       matrix:
         include:
-          - {os: macOS-latest}
+          - {os: macos-13}
+          - {os: macos-latest}
           - {os: ubuntu-latest}
 
     runs-on: ${{ matrix.os }}

ChangeLog

@@ -1,3 +1,35 @@
+2025-03-14  Dirk Eddelbuettel  <[email protected]>
+
+	* src/authenticate.cpp: Redefine in terms of -DHaveBlp flag and bring
+	if/else inside the function itself
+        * src/bdh.cpp: Idem
+        * src/bdp.cpp: Idem
+        * src/bds.cpp: Idem
+        * src/beqs.cpp: Idem
+        * src/blpConnect.cpp: Idem
+        * src/blpVersion.cpp: Idem
+        * src/blpapi_utils.cpp: Idem
+        * src/bsrch.cpp: Idem
+        * src/fieldsearch.cpp: Idem
+        * src/getBars.cpp: Idem
+        * src/getFieldInfo.cpp: Idem
+        * src/getTicks.cpp: Idem
+        * src/lookup.cpp: Idem
+        * src/subscribe.cpp: Idem
+
+	* src/blpVersion.cpp: Define simple haveBlp() helper
+	* man/haveBlp.Rd: Documentation for haveBlp()
+	* R/init.R: Use more explicit haveBlp()
+
+2025-03-13  Dirk Eddelbuettel  <[email protected]>
+
+	* DESCRIPTION (Version, Date): Roll micro version and date
+
+	* configure: Streamline and simplify conditional compilation
+	* src/Makevars.in: Idem
+
+	* .github/workflows/ci.yaml: Add macos-13 build for no-blp x86_64
+
 2025-03-12  John Laing  <[email protected]>
 
 	* src/authenticate.cpp: Correct duplicate export declaration

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: Rblpapi
 Title: R Interface to 'Bloomberg'
-Version: 0.3.15.2
-Date: 2025-03-09
+Version: 0.3.15.3
+Date: 2025-03-13
 Authors@R: c(person("Whit", "Armstrong", role = "aut"),
              person("Dirk", "Eddelbuettel", role = c("aut", "cre"), email = "[email protected]",
                     comment = c(ORCID = "0000-0001-6419-907X")),
@@ -18,7 +18,7 @@ SystemRequirements: A valid Bloomberg installation. The API headers and
  <https://www.bloomberg.com/professional/support/api-library/> for API
  documentation. Currently supported platforms are Windows and Linux (both for
  x86-64 processors only) as well as macOS (for arm64 only).  Other os-cpu pairings
- are not supported by Bloomberg and can therefore not be supported here.
+ are not supported by Bloomberg and can therefore not be fully supported here.
 URL: https://dirk.eddelbuettel.com/code/rblpapi.html, https://github.com/Rblp/Rblpapi
 BugReports: https://github.com/Rblp/Rblpapi/issues
 License: file LICENSE

R/RcppExports.R

@@ -59,6 +59,15 @@ getRuntimeVersion <- function() {
     .Call(`_Rblpapi_getRuntimeVersion`)
 }
 
+#' This function returns a boolean indicating whether Blp support is available.
+#'
+#' @title Get Blp availability in current build
+#' @return A logical indicating whether Blp was available at build.
+#' @author Dirk Eddelbuettel
+haveBlp <- function() {
+    .Call(`_Rblpapi_haveBlp`)
+}
+
 bsrch_Impl <- function(con, domain, limit, verbose = FALSE) {
     .Call(`_Rblpapi_bsrch_Impl`, con, domain, limit, verbose)
 }

R/init.R

@@ -21,16 +21,12 @@
 .pkgenv <- new.env(parent=emptyenv())
 
 .onAttach <- function(libname, pkgname) {
-    hrd <- getHeaderVersion()
-    rtm <- getRuntimeVersion()
-    if (nchar(hrd) + nchar(rtm) == 0) {
-        packageStartupMessage("No Blp available so no Rblapi functionality.")
-    } else {
+    if (haveBlp()) {
         packageStartupMessage(paste0("Rblpapi version ", packageVersion("Rblpapi"),
-                                     " using Blpapi headers ", hrd, " and run-time ", rtm, "."))
+                                     " using Blpapi headers ", getHeaderVersion(),
+                                     " and run-time ", getRuntimeVersion(), "."))
         packageStartupMessage(paste0("Please respect the Bloomberg licensing agreement ",
                                      "and terms of service."))
-
         if (getOption("blpAutoConnect", FALSE)) {
             con <- blpConnect()
             if (getOption("blpVerbose", FALSE)) {
@@ -49,5 +45,7 @@
         }
         assign("con", con, envir=.pkgenv)
         assign("blpAuth", blpAuth, envir=.pkgenv)
+    } else {
+        packageStartupMessage("No Blp available so no Rblapi functionality.")
     }
 }

configure

@@ -39,23 +39,23 @@ else
     echo "Check https://www.bloomberg.com/professional/support/api-library/ for possible support first."
     echo "Contributions welcome, see https://github.com/Rblp/blp for integration with Rblapi."
     echo "The build will proceed but not be functional for lack of a library."
-    sed -e"s/@config@//" -e"s/@badsystem@/-DNoBlpHere/" src/Makevars.in > src/Makevars
+    cp -ax src/Makevars.no_blp src/Makevars
     exit 0
 fi
 
 ## Populate Makevars
 arch=$(uname -m)
-if [ "${arch}" = "x86_64" -a "${platform}" = "linux" ]; then
+if [ "${arch}" = "x86_64" ] && [ "${platform}" = "linux" ]; then
     echo "Setting up compilation for a ${platform} ${arch} system"
-    sed -e"s/@config@/-lblpapi3_64/" -e"s/@badsystem@//" src/Makevars.in > src/Makevars
+    sed -e"s/@have_blp@/yes/" src/Makevars.in > src/Makevars
     flavour="64"
     # this used to matter when Blp supported x86 on macos, they no longer do
     #if [ "${platform}" = "osx" ]; then
     #    cpu="x86"
     #fi
-elif [ "${arch}" = "arm64" -a "${platform}" = "osx" ]; then
+elif [ "${arch}" = "arm64" ] && [ "${platform}" = "osx" ]; then
     echo "Setting up compilation for a ${platform} ${arch} system"
-    sed -e"s/@config@/-lblpapi3_64/" -e"s/@badsystem@//" src/Makevars.in > src/Makevars
+    sed -e"s/@have_blp@/yes/" src/Makevars.in > src/Makevars
     flavour="64"
     cpu="arm"
 #elif [ "${arch}" = "i686" ]; then
@@ -66,7 +66,7 @@ else
     echo "Unsupported platform and architecture combination: ${platform} ${arch}."
     echo "The build will proceed but not be functional for lack of a library."
     echo "If you need such a combination please get in touch with the Blp vendor."
-    sed -e"s/@config@//" -e"s/@badsystem@/-DNoBlpHere/" src/Makevars.in > src/Makevars
+    cp -ax src/Makevars.no_blp src/Makevars
     exit 0
 fi
 

man/blpAuthenticate.Rd

@@ -20,20 +20,21 @@
 ##  You should have received a copy of the GNU General Public License
 ##  along with Rblpapi.  If not, see <http://www.gnu.org/licenses/>.
 
-## filled in by configure
-BBG_LIB     = @config@
+## Overall 'do we expect to have blp support available' state filled in by configure
+##
+## (This variable is actually not used below and just left as a reminder 'how to' do
+## such replacements with `sed` from `configure`. The build with blp uses the same library
+## names throughout; we used to have 32 vs 64 bit builds in past.)
+HAVE_BLP = @have_blp@
+
+## this used to be filled in by configure but now both cases use the same value anyway
+BBG_LIB     = -lblpapi3_64
 BBG_RPATH   = '$$ORIGIN/../blp'
 
 ## set include and linker options
 ## Bbg API files are assummed to be in the standard search path
-PKG_CPPFLAGS = -I../inst/include/ -I. @badsystem@
+PKG_CPPFLAGS = -I../inst/include/ -I. -DHaveBlp
 PKG_LIBS     = $(BBG_LIB) -L../inst/blp -Wl,-rpath,$(BBG_RPATH)
 
 all: $(SHLIB)
-        # we rely on configure to replace @badsystem@ here to create a side effect
-        # notice that that there are only two outcomes we need to differentiate:
-        # - either (on a 'good' system with blp) we will in an empty string, so command -v works as
-        #   usual and we can run install_name_tool to add/update the rpath of shared librart
-        # - or on a bad system without blp we append -DNoBlpHere making command -v fail and avoiding
-        #   an install_name_call that would fails as we have no Rblpapi.so to adjust
-	@if command -v install_name_tool@badsystem@; then echo "fixing"; install_name_tool -add_rpath @loader_path/../blp Rblpapi.so; fi
+	@if command -v install_name_tool; then echo "fixing"; install_name_tool -add_rpath @loader_path/../blp Rblpapi.so; fi