Skip to content

Commit 13babe3

Browse files
committed
NEWS now links to GH issue tickets and pull requests
1 parent 23b66dd commit 13babe3

File tree

2 files changed

+47
-41
lines changed

2 files changed

+47
-41
lines changed

ChangeLog

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
2015-09-28 Dirk Eddelbuettel <[email protected]>
22

3+
* inst/NEWS.Rd: GitHub pull requests and issues are now linked
4+
35
* src/barrier.cpp: Use SET_STRING_ELT() on LHS (with thanks to Luke)
46

57
2015-09-21 Dirk Eddelbuettel <[email protected]>

inst/NEWS.Rd

Lines changed: 45 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
\name{NEWS}
22
\title{News for Package 'Rcpp'}
3-
\newcommand{\cpkg}{\href{https://CRAN.R-project.org/package=#1}{\pkg{#1}}}
4-
\newcommand{\ghpr}{\href{https://github.com/RcppCore/Rcpp/pull/#1}{\textsl{#1}}}
5-
\newcommand{\ghit}{\href{https://github.com/RcppCore/Rcpp/issue/#1}{\textsl{#1}}}
3+
\newcommand{\ghpr}{\href{https://github.com/RcppCore/Rcpp/pull/#1}{##1}}
4+
\newcommand{\ghit}{\href{https://github.com/RcppCore/Rcpp/issue/#1}{##1}}
65

76
\section{Changes in Rcpp version 0.12.2 (expected 2015-11-01 or later)}{
87
\itemize{
98
\item Changes in Rcpp API:
109
\itemize{
1110
\item Before creating a single String object from a \code{SEXP}, ensure
12-
that it is from a vector of length one (pull request #376; issue #375).
11+
that it is from a vector of length one (PR \ghpr{376} fixing \ghit{375}).
1312
\item No longer use \code{STRING_ELT} as left-hand side, thanks to a
14-
heads-up by Luke Tierney (pull request #378; issue #377).
13+
heads-up by Luke Tierney (PR \ghpr{378} fixing \ghit{377}).
14+
}
15+
\item Changes in Rcpp Documentation:
16+
\itemize{
17+
\item The \code{NEWS} file now links to GitHub issue tickets and pull
18+
requests.
1519
}
1620
}
1721
}
@@ -21,40 +25,40 @@
2125
\item Changes in Rcpp API:
2226
\itemize{
2327
\item Correct use of WIN32 instead of _WIN32 to please Windows 10
24-
\item Add an assignment operator to \code{DimNameProxy} (PR #339 by Florian)
28+
\item Add an assignment operator to \code{DimNameProxy} (PR \ghpr{339} by Florian)
2529
\item Add vector and matrix accessors \code{.at()} with bounds checking
26-
(PR #342 by Florian)
27-
\item Correct character vector conversion from single char (PR #344 by
28-
Florian fixing issue #343)
29-
\item Correct on use of \code{R_xlen_t} back to \code{size_t} (PR #348 by
30+
(PR \ghpr{342} by Florian)
31+
\item Correct character vector conversion from single char (PR \ghpr{344} by
32+
Florian fixing issue \ghit{343})
33+
\item Correct on use of \code{R_xlen_t} back to \code{size_t} (PR \ghpr{348} by
3034
Romain)
31-
\item Correct subsetting code to allow for single assignment (PR #349 by
35+
\item Correct subsetting code to allow for single assignment (PR \ghpr{349} by
3236
Florian)
33-
\item Enable subset assignment on left and righ-hand side (PR #353 by
34-
Qiang, fixing issue #345)
35-
\item Refreshed to included \code{tinyformat} template library (PR #357 by
36-
Dirk, issue #356)
37-
\item Add \code{operator<<()} for vectors and matrices (PR #361 by Dan
38-
fixing issue #239)
37+
\item Enable subset assignment on left and righ-hand side (PR \ghpr{353} by
38+
Qiang, fixing issue \ghit{345})
39+
\item Refreshed to included \code{tinyformat} template library (PR \ghpr{357} by
40+
Dirk, issue \ghit{356})
41+
\item Add \code{operator<<()} for vectors and matrices (PR \ghpr{361} by Dan
42+
fixing issue \ghit{239})
3943
\item Make \code{String} and \code{String_Proxy} objects comparable (PR
40-
#366 and PR #372 by Dan, fixing issue #191)
44+
\ghpr{366} and PR \ghpr{372} by Dan, fixing issue \ghit{191})
4145
\item Add a new class \code{Nullable} for objects which may be \code{NULL}
42-
(PR #368 by Dirk and Dan, fixing issue #363)
43-
\item Correct creation and access of large matrices (PR #370 by Florian,
44-
fixing issue #369)
46+
(PR \ghpr{368} by Dirk and Dan, fixing issue \ghit{363})
47+
\item Correct creation and access of large matrices (PR \ghpr{370} by Florian,
48+
fixing issue \ghit{369})
4549
}
4650
\item Changes in Rcpp Attributes:
4751
\itemize{
4852
\item Correctly reset directory in case of no-rebuilding but Windows code
49-
(PR #335 by Dirk)
53+
(PR \ghpr{335} by Dirk)
5054
}
5155
\item Changes in Rcpp Modules:
5256
\itemize{
5357
\item We no longer define multiple Modules objects named \code{World} in
5458
the unit tests with was seen to have a bad effect with R 3.2.2 or later
55-
(PR #351 by Dirk fixing issue #350).
59+
(PR \ghpr{351} by Dirk fixing issue \ghit{350}).
5660
\item Applied patch by Kurt Hornik which improves how Rcpp loads Modules
57-
(PR #353 by Dirk)
61+
(PR \ghpr{353} by Dirk)
5862
}
5963
\item Changes in Rcpp Documentation:
6064
\itemize{
@@ -72,21 +76,21 @@
7276
through \code{suppressMessages()}) were not properly respected.
7377
\item All internal length variables have been changed from \code{R_len_t}
7478
to \code{R_xlen_t} to support vectors longer than 2^31-1 elements (via
75-
pull request 303 by Qiang Kou).
79+
PR \ghpr{303} by Qiang Kou).
7680
\item The sugar function \code{sapply} now supports lambda functions
77-
(addressing issue 213 thanks to Matt Dziubinski)
81+
(addressing \ghit{213} thanks to Matt Dziubinski)
7882
\item The \code{var} sugar function now uses a more robust two-pass
79-
method, supports complex numbers, with new unit tests added (via pull
80-
request 320 by Matt Dziubinski)
81-
\item \code{String} constructors now allow encodings (via pull request 310
83+
method, supports complex numbers, with new unit tests added (via PR
84+
\ghpr{320} by Matt Dziubinski)
85+
\item \code{String} constructors now allow encodings (via PR \ghpr{310}
8286
by Qiang Kou)
8387
\item \code{String} objects are preserving the underlying \code{SEXP}
84-
objects better, and are more careful about initializations (via pull
85-
requests 322 and 329 by Qiang Kou)
86-
\item DataFrame constructors are now a little more careful (via pull
87-
request 301 by Romain Francois)
88+
objects better, and are more careful about initializations (via PRs
89+
\ghpr{322} and \ghpr{329} by Qiang Kou)
90+
\item DataFrame constructors are now a little more careful (via PR
91+
\ghpr{301} by Romain Francois)
8892
\item For R 3.2.0 or newer, \code{Rf_installChar()} is used instead of
89-
\code{Rf_install(CHAR())} (via pull request 332).
93+
\code{Rf_install(CHAR())} (via PR \ghpr{332}).
9094
}
9195
\item Changes in Rcpp Attributes:
9296
\itemize{
@@ -100,7 +104,7 @@
100104
\item Changes in Rcpp Documentation:
101105
\itemize{
102106
\item The \code{Rcpp-FAQ} vignette was once again updated with respect to
103-
OS X issues and Fortran libraries needed for e.g. \cpkg{RcppArmadillo}.
107+
OS X issues and Fortran libraries needed for e.g. \CRANpkg{RcppArmadillo}.
104108
\item The included \code{Rcpp.bib} bibtex file (which is also used by
105109
other Rcpp* packages) was updated with respect to its CRAN references.
106110
}
@@ -280,15 +284,15 @@
280284
\item Changes in Rcpp support functions:
281285
\itemize{
282286
\item The \code{Rcpp.package.skeleton()} function will now use
283-
\cpkg{pkgKitten} package, if available, to create a package which passes
287+
\CRANpkg{pkgKitten} package, if available, to create a package which passes
284288
\code{R CMD check} without warnings. A new \code{Suggests:} has been added
285-
for \cpkg{pkgKitten}.
289+
for \CRANpkg{pkgKitten}.
286290
\item The \code{modules=TRUE} case for \code{Rcpp.package.skeleton()} has
287291
been improved and now runs without complaints from \code{R CMD check} as well.
288292
}
289293
\item Changes in Rcpp unit test functions:
290294
\itemize{
291-
\item Functions from the \cpkg{RUnit} package are now prefixed with \code{RUnit::}
295+
\item Functions from the \CRANpkg{RUnit} package are now prefixed with \code{RUnit::}
292296
\item The \code{testRcppModule} and \code{testRcppClass} sample packages
293297
now pass \code{R CMD check --as-cran} cleanly with NOTES or WARNINGS
294298
}
@@ -331,7 +335,7 @@
331335
\itemize{
332336
\item Changes in Rcpp API:
333337
\itemize{
334-
\item Preserve backwards compatibility with \cpkg{Rcpp} 0.10.* by
338+
\item Preserve backwards compatibility with \CRANpkg{Rcpp} 0.10.* by
335339
allowing \code{RObject} extraction from vectors (or lists) of Rcpp
336340
objects
337341
\item Add missing default constructor to Reference class that was
@@ -382,7 +386,7 @@
382386
\itemize{
383387
\item Changes in Rcpp API:
384388
\itemize{
385-
\item Functions provided/used by \cpkg{Rcpp} are now registered
389+
\item Functions provided/used by \CRANpkg{Rcpp} are now registered
386390
with R and instantiated by client package alleviating the new for
387391
explicit linking against \code{libRcpp} which is therefore no
388392
longer created.
@@ -421,7 +425,7 @@
421425
\item Changes in Rcpp unit tests:
422426
\itemize{
423427
\item The file \code{tests/doRUnit.R} was rewritten following the
424-
pattern deployed in \cpkg{RProtoBuf} which is due to Murray Stokely
428+
pattern deployed in \CRANpkg{RProtoBuf} which is due to Murray Stokely
425429
\item The function \code{test()} was rewritten; it provides an
426430
easy entry point to running unit tests of the installed package
427431
}

0 commit comments

Comments
 (0)