Enable unit tests with negative indices

Florian Plaza Oñate · Florian Plaza Oñate · commit 62018cc2908c · 2015-08-20T12:08:17.000+02:00
diff --git a/inst/unitTests/runit.Matrix.R b/inst/unitTests/runit.Matrix.R
@@ -178,9 +178,9 @@ if (.runThisTest) {
         checkEquals(mat_access_with_bounds_checking(m, 3, 2), 12)
         checkException(mat_access_with_bounds_checking(m, 4, 2) , msg = "index out of bounds not detected" )
         checkException(mat_access_with_bounds_checking(m, 3, 3) , msg = "index out of bounds not detected" )
-        #checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
-        #checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
-        #checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
+        checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )
+        checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )
+        checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )
     }
 
 }
diff --git a/inst/unitTests/runit.Vector.R b/inst/unitTests/runit.Vector.R
@@ -688,7 +688,7 @@ if (.runThisTest) {
         x <- seq(1L, 5L, by=1L)
         checkEquals(vec_access_with_bounds_checking(x, 3), 4)
         checkException(vec_access_with_bounds_checking(x, 5) , msg = "index out of bounds not detected" )
-        #checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
+        checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -178,9 +178,9 @@ if (.runThisTest) {`
`178`	`178`	`checkEquals(mat_access_with_bounds_checking(m, 3, 2), 12)`
`179`	`179`	`checkException(mat_access_with_bounds_checking(m, 4, 2) , msg = "index out of bounds not detected" )`
`180`	`180`	`checkException(mat_access_with_bounds_checking(m, 3, 3) , msg = "index out of bounds not detected" )`
`181`		`- #checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )`
`182`		`- #checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )`
`183`		`- #checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )`
	`181`	`+ checkException(mat_access_with_bounds_checking(m, 3, -1) , msg = "index out of bounds not detected" )`
	`182`	`+ checkException(mat_access_with_bounds_checking(m, -1, 2) , msg = "index out of bounds not detected" )`
	`183`	`+ checkException(mat_access_with_bounds_checking(m, -1, -1) , msg = "index out of bounds not detected" )`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`}`
Original file line number	Diff line number	Diff line change
`@@ -688,7 +688,7 @@ if (.runThisTest) {`
`688`	`688`	`x <- seq(1L, 5L, by=1L)`
`689`	`689`	`checkEquals(vec_access_with_bounds_checking(x, 3), 4)`
`690`	`690`	`checkException(vec_access_with_bounds_checking(x, 5) , msg = "index out of bounds not detected" )`
`691`		`- #checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )`
	`691`	`+ checkException(vec_access_with_bounds_checking(x, -1) , msg = "index out of bounds not detected" )`
`692`	`692`	`}`
`693`	`693`	`}`
`694`	`694`