Skip to content

Commit 799b76e

Browse files
committed
Merge pull request #451 from qinwf/windows-rtools-3-3-0
Support R 3.3.0 Windows new toolchain
2 parents 682c0d4 + d3c4bd1 commit 799b76e

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

ChangeLog

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2016-03-27 Qin Wenfeng <[email protected]>
2+
3+
* R/Attributes.R: Support R 3.3.0 Windows new toolchain
4+
15
2016-03-26 Dirk Eddelbuettel <[email protected]>
26

37
* DESCRIPTION: Rolled Date and minor Version

R/Attributes.R

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -705,9 +705,11 @@ sourceCppFunction <- function(func, isVoid, dll, symbol) {
705705

706706
# Check version
707707
ver <- key$`Current Version`
708-
if (ver %in% (c("2.15", "2.16", "3.0", "3.1", "3.2", "3.3"))) {
708+
if (ver %in% (c("2.15", "2.16", "3.0", "3.1", "3.2", "3.3", "3.4"))) {
709709
# See if the InstallPath leads to the expected directories
710-
isGcc49 <- FALSE
710+
# R version 3.3.0 alpha (2016-03-25 r70378)
711+
isGcc49 <- ver %in% c("3.3", "3.4") && as.numeric(R.Version()$`svn rev`) >= 70378
712+
711713
rToolsPath <- key$`InstallPath`
712714
if (!is.null(rToolsPath)) {
713715
# add appropriate path entries
@@ -721,8 +723,10 @@ sourceCppFunction <- function(func, isVoid, dll, symbol) {
721723
env <- list()
722724
path <- paste(path, collapse = .Platform$path.sep)
723725
env$PATH <- paste(path, Sys.getenv("PATH"), sep=.Platform$path.sep)
724-
if (isGcc49)
725-
env$RTOOLS <- .rtoolsPath(rToolsPath)
726+
if (isGcc49) {
727+
env$RTOOLS <- .rtoolsPath(rToolsPath)
728+
env$BINPREF <- file.path(env$RTOOLS, "mingw_$(WIN)/bin//", fsep = "/")
729+
}
726730
return(env)
727731
}
728732
}

inst/NEWS.Rd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
The checks for different C library implementations now also check for Musl
1111
used by Alpine Linux (Sergio Marques in PR \ghpr{449}).
1212
}
13+
\item Changes in Rcpp Attributes:
14+
\itemize{
15+
R 3.3.0 Windows with Rtools 3.3 is now supported (Qin Wenfeng in PR \ghpr{451}).
16+
}
1317
}
1418
}
1519

0 commit comments

Comments
 (0)