Skip to content

Commit 7f846f4

Browse files
committed
also ensure CI=true set when running checks via Docker
1 parent 6868a31 commit 7f846f4

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
run: docker run --rm -i -v ${PWD}:/mnt -w /mnt ${{ matrix.cntr }} ${{matrix.r }} CMD build --no-build-vignettes --no-manual .
4949

5050
- name: Check
51-
run: docker run --rm -i -v ${PWD}:/mnt -w /mnt ${{ matrix.cntr }} ${{ matrix.r }} CMD check --no-vignettes --no-manual Rcpp_*.tar.gz
51+
run: docker run --rm -i -v ${PWD}:/mnt -w /mnt -e CI=true ${{ matrix.cntr }} ${{ matrix.r }} CMD check --no-vignettes --no-manual Rcpp_*.tar.gz
5252

5353
covr:
5454
runs-on: ubuntu-latest

ChangeLog

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
2021-01-16 Dirk Eddelbuettel <[email protected]>
22

3-
* tests/tinytest.R: Also test for CODECOV when deciding to run
4-
extensive tests or just a subset
3+
* tests/tinytest.R: Test for CODECOV when deciding to run extensive
4+
tests or just a subset, and set CI=true to enable run full set
55

66
2021-01-14 Dirk Eddelbuettel <[email protected]>
77

tests/tinytest.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ if (requireNamespace("tinytest", quietly=TRUE)) {
2424
## https://docs.travis-ci.com/user/environment-variables/#default-environment-variables
2525
## GitHub Action also set CI variable; see
2626
## https://docs.github.com/en/actions/reference/environment-variables
27-
## (but we may not see these as we are in Docker)
27+
## And we set it in 'docker run' call
2828
## Ensure Codecov runs full tests too
2929
if ((Sys.getenv("CI") == "true") ||
3030
(Sys.getenv("TRAVIS") == "true") ||

0 commit comments

Comments
 (0)