Revert changes to modules related to BEGIN/END macros

It appears as if moving the BEGIN/END handling out to the highest level of the modules code allowed exceptiosn to propagate across the boundary between user DLLs and the Rcpp DLL, thus causing a crash on Windows.

This changes reverts all of the modules related changes to BEGIN/END handling, essentially leaving them exactly as they were (and allowing our tests to continue passing).

AFAIK we need to either do this or need to rework the modules code so that the exceptions no longer propagate (I don't think just surpressing the test on Windows is an option as this represents a change in behavior which may crash packages currently on CRAN).

Author: jjallaire

inst/include/Rcpp/InternalFunctionWithStdFunction.h

@@ -38,8 +38,10 @@ namespace Rcpp {
                 virtual ~CppFunctionBaseFromStdFunction() {}
 
                 SEXP operator()(SEXP* args) {
+                    BEGIN_RCPP
                     auto result = call<RESULT_TYPE, Args...>(fun, args);
                     return Rcpp::module_wrap<RESULT_TYPE>(result);
+                    END_RCPP
                 }
 
             private:
@@ -53,8 +55,9 @@ namespace Rcpp {
                  virtual ~CppFunctionBaseFromStdFunction() {}
 
                  SEXP operator()(SEXP* args) {
+                     BEGIN_RCPP
                      call<void, Args...>(fun, args);
-                     return R_NilValue;
+                     END_RCPP
                  }
 
             private:

inst/include/Rcpp/api/meat/module/Module.h

@@ -1,6 +1,6 @@
 // Module.h: Rcpp R/C++ interface class library -- Rcpp modules
 //
-// Copyright (C) 2013 - 2015 Romain Francois
+// Copyright (C) 2013 Romain Francois
 //
 // This file is part of Rcpp.
 //
@@ -37,10 +37,12 @@ namespace Rcpp {
 	}
 
     inline CppClass Module::get_class( const std::string& cl ){
+        BEGIN_RCPP
             CLASS_MAP::iterator it = classes.find(cl) ;
             if( it == classes.end() ) throw std::range_error( "no such class" ) ;
             std::string buffer ;
             return CppClass( this, it->second, buffer ) ;
+        END_RCPP
     }
 
 }