Skip to content

Commit c1f868d

Browse files
authored
Merge pull request #1189 from RcppCore/feature/cxx-flags-quote
quote path in CxxFlags
2 parents 4dde500 + 630615b commit c1f868d

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

ChangeLog

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
2021-11-14 Dirk Eddelbuettel <[email protected]>
2+
3+
* R/RcppLdpath.R: Simplified as we no longer need to worry about CXX0X
4+
5+
2021-11-11 Kevin Ushey <[email protected]>
6+
7+
* R/RcppLdpath.R: CxxFlags() now quotes its include path
8+
19
2021-10-15 Travers Ching <[email protected]>
210

311
* inst/tinytest/testRcppAttributePackage: Tests `signature` attribute

R/RcppLdpath.R

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,11 @@ canUseCXX0X <- function() { TRUE } # .Call( "canUseCXX0X", PACKAGE = "Rcpp" )
4747

4848
## Provide compiler flags -- i.e. -I/path/to/Rcpp.h
4949
RcppCxxFlags <- function(cxx0x=FALSE) {
50-
# path <- RcppLdPath()
5150
path <- Rcpp.system.file( "include" )
5251
if (.Platform$OS.type=="windows") {
5352
path <- asBuildPath(path) # #nocov
5453
}
55-
paste("-I", path, if (cxx0x && canUseCXX0X()) " -std=c++0x" else "", sep="")
54+
paste0('-I"', path, '"')
5655
}
5756

5857
## Shorter names, and call cat() directly
@@ -82,5 +81,5 @@ RcppCxx0xFlags <- function() {
8281
}
8382

8483
Cxx0xFlags <- function() {
85-
cat( RcppCxx0xFlags() ) # #nocov end
84+
cat(RcppCxx0xFlags()) # #nocov end
8685
}

inst/NEWS.Rd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
extensive discussion in \ghit{1158}.
1212
\item A new \code{#define} allows default setting of finalizer
1313
calls for external pointers (Iñaki in \ghpr{1180} closing \ghit{1108}).
14+
\item `Rcpp:::CxxFlags()` now quotes the include path generated,
15+
closing \ghit{1188}.
1416
}
1517
\item Changes in Rcpp Documentation:
1618
\itemize{

0 commit comments

Comments
 (0)