Skip to content

Commit f46b724

Browse files
Add missing includes (#1272)
* Add missing includes * Update date.cpp * Update ChangeLog * Update PULL_REQUEST_TEMPLATE.md
1 parent 85d59f7 commit f46b724

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ Please explain the changes you want to apply to Rcpp, preferably in an issue tic
77

88
- [ ] Code compiles correctly
99
- [ ] `R CMD check` still passes all tests
10-
- [ ] Prefereably, new tests were added which fail without the change
10+
- [ ] Preferably, new tests were added which fail without the change
1111
- [ ] Document the changes by file in [ChangeLog](https://github.com/RcppCore/Rcpp/blob/master/ChangeLog)

ChangeLog

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
2023-08-03 Michael Chirico <[email protected]>
2+
3+
* src/attributes.cpp: Directly `#include <ostream>` for `std::endl`
4+
* src/date.cpp: Directly `#include <R_ext/Booelan.h>` for `TRUE` and `FALSE`
5+
16
2023-07-03 Dirk Eddelbuettel <[email protected]>
27

38
* DESCRIPTION (Date, Version): Release 1.0.11

src/attributes.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
#include <map>
3232
#include <set>
3333
#include <algorithm>
34+
#include <ostream> // for std::endl
3435
#include <fstream>
3536
#include <sstream>
3637

src/date.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#define COMPILING_RCPP
2727

28+
#include <R_ext/Boolean.h> // for TRUE,FALSE
2829
#include <Rcpp.h>
2930
#include <time.h> // for gmtime
3031
#include <Rcpp/exceptions.h>

0 commit comments

Comments
 (0)