Skip to content

Commit f4e8a60

Browse files
committed
comment-out R::pythag
1 parent fc8ebec commit f4e8a60

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

ChangeLog

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
1+
2018-02-28 Dirk Eddelbuettel <[email protected]>
2+
3+
* inst/include/Rcpp/Rmath.h (R): Rf_pythag has been remove in R 2.14.0
4+
so comment-out the R::pythag wrapper (per request of Brian Ripley)
5+
16
2018-02-26 Kevin Ushey <[email protected]>
27

38
* src/api.cpp: Always set / put RNG state when calling Rcpp function
49

5-
610
2018-02-25 Dirk Eddelbuettel <[email protected]>
711

812
* vignettes/Rcpp.bib: Updated

inst/NEWS.Rd

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
\item Rcpp now sets and puts the RNG state upon each entry to an Rcpp
1111
function, ensuring that nested invocations of Rcpp functions manage the
1212
RNG state as expected
13+
\item The \code{R::pythag} wrapper has been commented out as underlying
14+
function has been gone from R since release 2.14.0.
1315
}
1416
\itemize{
1517
\item The \code{long long} type can now be used on 64-bit Windows (Kevin

inst/include/Rcpp/Rmath.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ namespace R {
219219
#ifndef HAVE_HYPOT
220220
inline double hypot(double a, double b) { return ::Rf_hypot(a, b); }
221221
#endif
222-
inline double pythag(double a, double b) { return ::Rf_pythag(a, b); }
222+
/* Gone since R 2.14.0 according to Brian Ripley and is now comment out per his request */
223+
/* inline double pythag(double a, double b) { return ::Rf_pythag(a, b); } */
223224
#ifndef HAVE_EXPM1
224225
inline double expm1(double x); /* = exp(x)-1 {care for small x} */ { return ::Rf_expm1(x); }
225226
#endif

0 commit comments

Comments
 (0)