Lay the ground for Rf_error masking (#1402) (#1407)

* Lay the ground for Rf_error masking (#1402)

* Add a message at compilation time
* Protect the valid Rf_error calls generated by Rcpp

* some rewording to fit the ChangeLog text in two lines

* messages are considered statements by gcc and cannot be used safely; switching to a warning

* rebase fix

* emit a message instead of a warning using an internal wrapper

* remove space

* Revert "remove space"

This reverts commit bb86312.

* Revert "emit a message instead of a warning using an internal wrapper"

This reverts commit 9d409e8.

* comment out warning

* add on switch

Author: Enchufa2

ChangeLog

@@ -104,6 +104,15 @@
 	or related R headers were installed first
 	* inst/include/RcppCommon.h: Call new header as first thing
 
+2025-11-12 Iñaki Ucar <[email protected]>
+
+	* inst/include/Rcpp/macros/mask.h: Lay the ground for Rf_error masking
+	with a warning at compilation time unless RCPP_NO_MASK_RF_ERROR is defined
+	* inst/include/RcppCommon.h: Include the previous file in the last place
+	* src/attributes.cpp: Use parentheses to protect call to Rf_error
+	* inst/tinytest/cpp/stack.cpp: Idem
+	* inst/tinytest/testRcppInterfaceExporter/src/RcppExports.cpp: Idem
+
 2025-11-04  Dirk Eddelbuettel  <[email protected]>
 
 	* .github/workflows/macos.yaml (jobs): Roll macos-13 to macos-14
@@ -116,7 +125,7 @@
 
 2025-10-21 Iñaki Ucar <[email protected]>
 
-	* inst/include/Rcpp/exceptions_impl.h: use __has_include to simplify checks
+	* inst/include/Rcpp/exceptions_impl.h: Use __has_include to simplify checks
 	to enable demangling, making them robust for more platforms
 
 2025-10-13  Dirk Eddelbuettel  <[email protected]>

inst/include/Rcpp/macros/mask.h

@@ -0,0 +1,35 @@
+// mask.h: Rcpp R/C++ interface class library -- masking macros
+//
+// Copyright (C) 2025        Iñaki Ucar
+//
+// This file is part of Rcpp.
+//
+// Rcpp is free software: you can redistribute it and/or modify it
+// under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 2 of the License, or
+// (at your option) any later version.
+//
+// Rcpp is distributed in the hope that it will be useful, but
+// WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Rcpp.  If not, see <http://www.gnu.org/licenses/>.
+
+#ifndef Rcpp_macros_mask_h
+#define Rcpp_macros_mask_h
+
+#ifndef RCPP_NO_MASK_RF_ERROR
+#ifdef RCPP_MASK_RF_ERROR
+#define Rf_error(...) \
+    _Pragma("GCC warning \"Use of Rf_error() instead of Rcpp::stop(). Calls \
+to Rf_error() in C++ contexts are unsafe: consider using Rcpp::stop() instead, \
+or define RCPP_NO_MASK_RF_ERROR if this is a false positive. More info:\n\
+ - https://github.com/RcppCore/Rcpp/issues/1247\n\
+ - https://github.com/RcppCore/Rcpp/pull/1402\"") \
+    Rf_error(__VA_ARGS__)
+#endif
+#endif
+
+#endif

inst/include/RcppCommon.h

@@ -190,4 +190,6 @@ namespace Rcpp {
 
 #include <Rcpp/internal/wrap.h>
 
+#include <Rcpp/macros/mask.h>
+
 #endif

inst/tinytest/cpp/stack.cpp

@@ -2,7 +2,8 @@
 //
 // misc.cpp: Rcpp R/C++ interface class library -- misc unit tests
 //
-// Copyright (C) 2013 - 2022  Dirk Eddelbuettel and Romain Francois
+// Copyright (C) 2013 - 2024  Dirk Eddelbuettel and Romain Francois
+// Copyright (C) 2025         Dirk Eddelbuettel, Romain Francois and Iñaki Ucar
 //
 // This file is part of Rcpp.
 //
@@ -55,7 +56,7 @@ SEXP testSendInterrupt() {
 SEXP maybeThrow(void* data) {
     bool* fail = (bool*) data;
     if (*fail)
-        Rf_error("throw!");
+        (Rf_error)("throw!"); // prevent masking
     else
         return NumericVector::create(42);
 }

inst/tinytest/testRcppInterfaceExporter/src/RcppExports.cpp

@@ -43,7 +43,7 @@ RcppExport SEXP _testRcppInterfaceExporter_test_cpp_interface(SEXP xSEXP, SEXP f
     if (rcpp_isError_gen) {
         SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);
         UNPROTECT(1);
-        Rf_error("%s", CHAR(rcpp_msgSEXP_gen));
+        (Rf_error)("%s", CHAR(rcpp_msgSEXP_gen));
     }
     UNPROTECT(1);
     return rcpp_result_gen;

src/attributes.cpp

@@ -2953,7 +2953,8 @@ namespace attributes {
                      << "    if (rcpp_isError_gen) {" << std::endl
                      << "        SEXP rcpp_msgSEXP_gen = Rf_asChar(rcpp_result_gen);" << std::endl
                      << "        UNPROTECT(1);" << std::endl
-                     << "        Rf_error(\"%s\", CHAR(rcpp_msgSEXP_gen));" << std::endl
+                                 // Parentheses to prevent masking
+                     << "        (Rf_error)(\"%s\", CHAR(rcpp_msgSEXP_gen));" << std::endl
                      << "    }" << std::endl
                      << "    UNPROTECT(1);" << std::endl
                      << "    return rcpp_result_gen;" << std::endl