simplify setting options in .onLoad

Author: MichaelChirico

R/onLoad.R

@@ -73,28 +73,28 @@
   # In fread and fwrite we have moved back to using getOption's default argument since it is unlikely fread and fread will be called in a loop many times, plus they
   # are relatively heavy functions where the overhead in getOption() would not be noticed.  It's only really [.data.table where getOption default bit.
   # Improvement to base::getOption() now submitted (100x; 5s down to 0.05s):  https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17394
-  opts = c("datatable.verbose"="FALSE",        # datatable.<argument name>
-       "datatable.optimize"="Inf",             # datatable.<argument name>
-       "datatable.print.nrows"="100L",         # datatable.<argument name>
-       "datatable.print.topn"="5L",            # datatable.<argument name>
-       "datatable.print.class"="TRUE",         # for print.data.table
-       "datatable.print.rownames"="TRUE",      # for print.data.table
-       "datatable.print.colnames"="'auto'",    # for print.data.table
-       "datatable.print.keys"="TRUE",          # for print.data.table
-       "datatable.print.trunc.cols"="FALSE",   # for print.data.table
-       "datatable.show.indices"="FALSE",       # for print.data.table
-       "datatable.allow.cartesian"="FALSE",    # datatable.<argument name>
-       "datatable.join.many"="TRUE",           # mergelist, [.data.table #4383 #914
-       "datatable.dfdispatchwarn"="TRUE",                   # not a function argument
-       "datatable.warnredundantby"="TRUE",                  # not a function argument
-       "datatable.alloccol"="1024L",           # argument 'n' of alloc.col. Over-allocate 1024 spare column slots
-       "datatable.auto.index"="TRUE",          # DT[col=="val"] to auto add index so 2nd time faster
-       "datatable.use.index"="TRUE",           # global switch to address #1422
-       "datatable.prettyprint.char" = NULL     # FR #1091
-       )
-  for (i in setdiff(names(opts),names(options()))) {
-    eval(parse(text=paste0("options(",i,"=",opts[i],")")))
-  }
+  opts = list(
+    datatable.verbose=FALSE,            # datatable.<argument name>
+    datatable.optimize=Inf,             # datatable.<argument name>
+    datatable.print.nrows=100L,         # datatable.<argument name>
+    datatable.print.topn=5L,            # datatable.<argument name>
+    datatable.print.class=TRUE,         # for print.data.table
+    datatable.print.rownames=TRUE,      # for print.data.table
+    datatable.print.colnames='auto',    # for print.data.table
+    datatable.print.keys=TRUE,          # for print.data.table
+    datatable.print.trunc.cols=FALSE,   # for print.data.table
+    datatable.show.indices=FALSE,       # for print.data.table
+    datatable.allow.cartesian=FALSE,    # datatable.<argument name>
+    datatable.join.many=TRUE,           # mergelist, [.data.table #4383 #914
+    datatable.dfdispatchwarn=TRUE,      # not a function argument
+    datatable.warnredundantby=TRUE,     # not a function argument
+    datatable.alloccol=1024L,           # argument 'n' of alloc.col. Over-allocate 1024 spare column slots
+    datatable.auto.index=TRUE,          # DT[col=="val"] to auto add index so 2nd time faster
+    datatable.use.index=TRUE,           # global switch to address #1422
+    datatable.prettyprint.char=NULL     # FR #1091
+  )
+  opts = opts[!names(opts) %chin% names(options())]
+  options(opts)
 
   # Test R behaviour that changed in v3.1 and is now depended on
   x = 1L:3L