Skip to content

Commit 0f1b434

Browse files
committed
suppressed warnings
1 parent cf7fb11 commit 0f1b434

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@
7878
7979
17. A data.table with a column of class `vctrs_list_of` (from package {vctrs}) prints as expected, [#5948](https://github.com/Rdatatable/data.table/issues/5948). Before, they could be printed messily, e.g. printing every entry in a nested data.frame. Thanks @jesse-smith for the report, @DavisVaughan and @r2evans for contributing, and @MichaelChirico for the PR.
8080
81+
18. `cube()`, `rollup()`, and `groupingsets()` no longer produce a spurious warning when using `min()` or `max()` as aggregations, [#6964](https://github.com/Rdatatable/data.table/issues/6964). Thanks @ferenci-tamas for the report and @venom1204 for the fix.
82+
8183
### NOTES
8284
8385
1. Continued work to remove non-API C functions, [#6180](https://github.com/Rdatatable/data.table/issues/6180). Thanks Ivan Krylov for the PRs and for writing a clear and concise guide about the R API: https://aitap.codeberg.page/R-api/.

R/groupingsets.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ groupingsets.data.table = function(x, j, by, sets, .SDcols, id = FALSE, jj, labe
115115
# inline all arguments that might clash with enclosing environment
116116
pcall = substitute(x[0L, jj, by], list(x = x, jj = jj, by = by))
117117
if (length(.SDcols)) pcall$.SDcols = .SDcols
118-
empty = eval(pcall, list(.datatable.aware = TRUE), enclos)
118+
empty = suppressWarnings(eval(pcall, list(.datatable.aware = TRUE), enclos))
119119
if (id && "grouping" %chin% names(empty)) # `j` could have been evaluated to `grouping` field
120120
stopf("When using `id=TRUE` the 'j' expression must not evaluate to a column named 'grouping'.")
121121
if (anyDuplicated(names(empty)) > 0L)

0 commit comments

Comments
 (0)