Skip to content

Commit 18662cc

Browse files
committed
use na.rm=F to avoid error
1 parent 89ee912 commit 18662cc

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

.ci/atime/tests.R

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -251,15 +251,14 @@ test.list <- atime::atime_test_list(
251251
Before = "f339aa64c426a9cd7cf2fcb13d91fc4ed353cd31", # Parent of the first commit https://github.com/Rdatatable/data.table/commit/fcc10d73a20837d0f1ad3278ee9168473afa5ff1 in the PR https://github.com/Rdatatable/data.table/pull/6393/commits with major change to fwrite with gzip.
252252
PR = "3630413ae493a5a61b06c50e80d166924d2ef89a"), # Close-to-last merge commit in the PR.
253253

254-
# Test case created directly using the atime code below (not adapted from any other benchmark), based on the PR Removes unnecessary data.table call from as.data.table.array https://github.com/Rdatatable/data.table/pull/7010
254+
# Test case created directly using the atime code below (not adapted from any other benchmark), based on the PR, Removes unnecessary data.table call from as.data.table.array https://github.com/Rdatatable/data.table/pull/7010
255255
"as.data.table.array improved in #7010" = atime::atime_test(
256-
N = 1:10,
257256
setup = {
258-
dims = N * c(5L, 5L, 30L, 1L)
257+
dims = c(N, 1, 1)
259258
arr = array(seq_len(prod(dims)), dim=dims)
260259
},
261-
expr = data.table::as.data.table(arr),
262-
Slow = "73d79edf8ff8c55163e90631072192301056e336", # Parent of the first commit https://github.com/Rdatatable/data.table/tree/73d79edf8ff8c55163e90631072192301056e336
260+
expr = data.table:::as.data.table.array(arr, na.rm=FALSE),
261+
Slow = "73d79edf8ff8c55163e90631072192301056e336", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/8397dc3c993b61a07a81c786ca68c22bc589befc)
263262
Fast = "653e2eee6d280335fe4be60845e037c039b66b38"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/7019/commits) that fixes the slow code
264263

265264
tests=extra.test.list)

0 commit comments

Comments
 (0)