Skip to content

Commit 2001816

Browse files
committed
rerun benchmarks single threaded
1 parent d02df36 commit 2001816

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

NEWS.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,18 @@
3434

3535
```R
3636
x = sample(2e8)
37+
setDTthreads(1) # single threaded for fair comparison, will get faster with more threads
3738
microbenchmark::microbenchmark(
3839
base = rev(x),
3940
frev_copy = frev(x, copy=TRUE),
4041
frev_inplace = frev(x, copy=FALSE),
4142
times = 10L,
4243
unit = "s"
4344
)
44-
# Unit: seconds
45-
# expr min lq mean median uq max neval cld
46-
# base 1.376 1.397 1.864 1.544 1.917 4.274 10 a
47-
# frev_copy 0.529 0.591 0.769 0.659 0.727 1.351 10 b
48-
# frev_inplace 0.064 0.065 0.066 0.066 0.067 0.070 10 c
45+
# expr min lq mean median uq max neval cld
46+
# base 1.240 1.263 1.301 1.291 1.329 1.437 10 a
47+
# frev_copy 0.533 0.538 0.590 0.576 0.639 0.667 10 b
48+
# frev_inplace 0.099 0.101 0.130 0.102 0.107 0.260 10 c
4949
```
5050

5151
## NOTES

src/utils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ SEXP startsWithAny(const SEXP x, const SEXP y, SEXP start) {
425425
}
426426

427427
SEXP frev(SEXP x, SEXP copyArg) {
428-
if (INHERITS(x, char_dataframe) || INHERITS(x, char_datatable))
428+
if (INHERITS(x, char_dataframe))
429429
error(_("'x' should not be data.frame or data.table."));
430430
if (!isNull(getAttrib(x, R_DimSymbol)))
431431
error(_("'x' should not be matrix or array"));

0 commit comments

Comments
 (0)