Skip to content

Commit 2cf5d25

Browse files
committed
Explicitly list the size as a numeric instead of integer.
Modified NEWS and DESCRIPTION files to include details pertaining to the PR.
1 parent 48ef7f9 commit 2cf5d25

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

DESCRIPTION

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,5 +92,6 @@ Authors@R: c(
9292
person("Ivan", "Krylov", role="ctb"),
9393
person("Angel", "Feliz", role="ctb"),
9494
person("Michael","Young", role="ctb"),
95-
person("Mark", "Seeto", role="ctb")
95+
person("Mark", "Seeto", role="ctb"),
96+
person("Vijay", "Lulla", role="ctb")
9697
)

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ rowwiseDT(
105105
106106
10. `DT[1, on=NULL]` now works for returning the first row, [#6579](https://github.com/Rdatatable/data.table/issues/6579). Thanks to @Kodiologist for the report and @tdhock for the PR.
107107
108+
11. `tables()` does not return NA as size for large data tables, [#6607](https://github.com/Rdatatable/data.table/issues/6607). Thanks to @vlulla for the report and the PR.
109+
108110
## NOTES
109111
110112
1. Tests run again when some Suggests packages are missing, [#6411](https://github.com/Rdatatable/data.table/issues/6411). Thanks @aadler for the note and @MichaelChirico for the fix.

inst/tests/other.Rraw

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,5 +771,5 @@ if (loaded[["nanotime"]]) {
771771
.e <- new.env() ## to not populate the .GlobalEnv
772772
.e[["DT"]] <- as.data.table(lapply(1:15,function(i) runif(20e6)))
773773
res <- tables(env=.e)
774-
test(32, res[, .(NAME,NROW,NCOL,MB)], data.table(NAME="DT",NROW=20000000L,NCOL=15L,MB=2288))
774+
test(32, res[, .(NAME,NROW,NCOL,MB)], data.table(NAME="DT",NROW=20000000L,NCOL=15L,MB=2288.0))
775775
rm(.e, res)

0 commit comments

Comments
 (0)