|
| 1 | +dt_linters = new.env() |
| 2 | +for (f in list.files('.ci/linters/r', full.names=TRUE)) sys.source(f, dt_linters) |
| 3 | +rm(f) |
| 4 | + |
| 5 | +# NB: Could do this inside the linter definition, this separation makes those files more standardized |
| 6 | +dt_linters <- eapply(dt_linters, function(linter_factory) linter_factory()) |
| 7 | + |
| 8 | +linters = c(dt_linters, all_linters( |
| 9 | + packages = "lintr", # TODO(lintr->3.2.0): Remove this. |
| 10 | + # eq_assignment_linter(), |
| 11 | + brace_linter(allow_single_line = TRUE), |
| 12 | + # TODO(michaelchirico): Activate these incrementally. These are the |
| 13 | + # parameterizations that match our style guide. |
| 14 | + # implicit_assignment_linter(allow_lazy = TRUE, allow_scoped = TRUE), |
| 15 | + # implicit_integer_linter(allow_colon = TRUE), |
| 16 | + # system_time_linter = undesirable_function_linter(c( |
| 17 | + # system.time = "Only run timings in benchmark.Rraw" |
| 18 | + # )), |
| 19 | + # undesirable_function_linter(modify_defaults( |
| 20 | + # default_undesirable_functions, |
| 21 | + # ifelse = "Use fifelse instead.", |
| 22 | + # Sys.setenv = NULL, |
| 23 | + # library = NULL, |
| 24 | + # options = NULL, |
| 25 | + # par = NULL, |
| 26 | + # setwd = NULL |
| 27 | + # )), |
| 28 | + undesirable_operator_linter(), |
| 29 | + # TODO(lintr#2441): Use upstream implementation. |
| 30 | + assignment_linter = NULL, |
| 31 | + absolute_path_linter = NULL, # too many false positives |
| 32 | + # TODO(lintr#2442): Use this once x[ , j, by] is supported. |
| 33 | + commas_linter = NULL, |
| 34 | + commented_code_linter = NULL, |
| 35 | + # TODO(linter->3.2.0): Activate this. |
| 36 | + consecutive_assertion_linter = NULL, |
| 37 | + cyclocomp_linter = NULL, |
| 38 | + function_argument_linter = NULL, |
| 39 | + indentation_linter = NULL, |
| 40 | + infix_spaces_linter = NULL, |
| 41 | + line_length_linter = NULL, |
| 42 | + missing_package_linter = NULL, |
| 43 | + namespace_linter = NULL, |
| 44 | + nonportable_path_linter = NULL, |
| 45 | + object_name_linter = NULL, |
| 46 | + object_usage_linter = NULL, |
| 47 | + quotes_linter = NULL, |
| 48 | + semicolon_linter = NULL, |
| 49 | + spaces_inside_linter = NULL, |
| 50 | + spaces_left_parentheses_linter = NULL, |
| 51 | + # TODO(michaelchirico): Only exclude from vignettes, not sure what's wrong. |
| 52 | + strings_as_factors_linter = NULL, |
| 53 | + # TODO(lintr->3.2.0): Fix on a valid TODO style, enforce it, and re-activate. |
| 54 | + todo_comment_linter = NULL, |
| 55 | + # TODO(michaelchirico): Enforce these and re-activate them one-by-one. |
| 56 | + brace_linter = NULL, |
| 57 | + fixed_regex_linter = NULL, |
| 58 | + if_not_else_linter = NULL, |
| 59 | + implicit_assignment_linter = NULL, |
| 60 | + implicit_integer_linter = NULL, |
| 61 | + keyword_quote_linter = NULL, |
| 62 | + object_overwrite_linter = NULL, |
| 63 | + paren_body_linter = NULL, |
| 64 | + redundant_equals_linter = NULL, |
| 65 | + undesirable_function_linter = NULL, |
| 66 | + unnecessary_concatenation_linter = NULL, |
| 67 | + unnecessary_nesting_linter = NULL, |
| 68 | + unreachable_code_linter = NULL, |
| 69 | + unused_import_linter = NULL |
| 70 | +)) |
| 71 | +rm(dt_linters) |
| 72 | + |
| 73 | +# TODO(lintr#2172): Glob with lintr itself. |
| 74 | +exclusions = c(local({ |
| 75 | + exclusion_for_dir <- function(dir, exclusions) { |
| 76 | + files = file.path("..", list.files(dir, pattern = "\\.(R|Rmd|Rraw)$", full.names=TRUE)) |
| 77 | + stats::setNames(rep(list(exclusions), length(files)), files) |
| 78 | + } |
| 79 | + c( |
| 80 | + exclusion_for_dir("tests", list( |
| 81 | + quotes_linter = Inf, |
| 82 | + # TODO(michaelchirico): Enforce these and re-activate them one-by-one. |
| 83 | + implicit_integer_linter = Inf, |
| 84 | + infix_spaces_linter = Inf, |
| 85 | + undesirable_function_linter = Inf |
| 86 | + )), |
| 87 | + exclusion_for_dir("vignettes", list( |
| 88 | + quotes_linter = Inf, |
| 89 | + sample_int_linter = Inf |
| 90 | + # strings_as_factors_linter = Inf |
| 91 | + # system_time_linter = Inf |
| 92 | + )), |
| 93 | + exclusion_for_dir("inst/tests", list( |
| 94 | + library_call_linter = Inf, |
| 95 | + numeric_leading_zero_linter = Inf, |
| 96 | + undesirable_operator_linter = Inf, # For ':::', possibly we could be more careful to only exclude ':::'. |
| 97 | + # TODO(michaelchirico): Enforce these and re-activate them one-by-one. |
| 98 | + comparison_negation_linter = Inf, |
| 99 | + condition_call_linter = Inf, |
| 100 | + duplicate_argument_linter = Inf, |
| 101 | + equals_na_linter = Inf, |
| 102 | + missing_argument_linter = Inf, |
| 103 | + paste_linter = Inf, |
| 104 | + rep_len_linter = Inf, |
| 105 | + sample_int_linter = Inf, |
| 106 | + seq_linter = Inf, |
| 107 | + unnecessary_lambda_linter = Inf |
| 108 | + )) |
| 109 | + ) |
| 110 | +}), |
| 111 | + list(`../inst/tests/froll.Rraw` = list(dt_test_literal_linter = Inf)) # TODO(michaelchirico): Fix these once #5898, #5692, #5682, #5576, #5575, #5441 are merged. |
| 112 | +) |
0 commit comments