Skip to content

Commit 35a0a26

Browse files
committed
added test and the news
1 parent 83d1859 commit 35a0a26

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,8 @@ rowwiseDT(
198198
199199
20. Fixed a memory issue causing segfaults in `forder`, [#6797](https://github.com/Rdatatable/data.table/issues/6797). Thanks @dkutner for the report and @MichaelChirico for the fix.
200200
201+
21. `setDT(get0('var'))` now correctly modifies `var` by reference, consistent with the long-standing behavior of `setDT(get('var'))`. Previously, the `.internal.selfref` attribute was not set, [#6864](https://github.com/Rdatatable/data.table/issues/6864). Thanks to @rikivillalba for the report and @venom1204 for the fix.
202+
201203
### NOTES
202204
203205
1. There is a new vignette on joins! See `vignette("datatable-joins")`. Thanks to Angel Feliz for authoring it! Feedback welcome. This vignette has been highly requested since 2017: [#2181](https://github.com/Rdatatable/data.table/issues/2181).

inst/tests/tests.Rraw

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21183,3 +21183,11 @@ test(2317.6, DT1[DF1, on='a', .(d = x.a + i.d)]$d, 5)
2118321183
test(2317.7, DT1[DF2, on='a', e := i.e]$e, 5)
2118421184
test(2317.8, DT1[DF2, on='a', e2 := x.a + i.e]$e2, 6)
2118521185
test(2317.9, DT1[DF2, on='a', .(e = x.a + i.e)]$e, 6)
21186+
21187+
#6864
21188+
ds = copy(datasets::iris)
21189+
x = setDT(get("ds"))
21190+
test(2319.1, !is.null(attr(ds, ".internal.selfref")))
21191+
x = setDT(get0("ds"))
21192+
test(2319.2, !is.null(attr(ds, ".internal.selfref")))
21193+
test(2319.3, identical(ds, x))

0 commit comments

Comments
 (0)