Skip to content

Commit 3defa21

Browse files
committed
Fixes atest mixup
1 parent c9b38d6 commit 3defa21

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

.ci/atime/tests.R

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -251,19 +251,17 @@ test.list <- atime::atime_test_list(
251251
Before = "f339aa64c426a9cd7cf2fcb13d91fc4ed353cd31", # Parent of the first commit https://github.com/Rdatatable/data.table/commit/fcc10d73a20837d0f1ad3278ee9168473afa5ff1 in the PR https://github.com/Rdatatable/data.table/pull/6393/commits with major change to fwrite with gzip.
252252
PR = "3630413ae493a5a61b06c50e80d166924d2ef89a"), # Close-to-last merge commit in the PR.
253253

254-
tests=extra.test.list)
255-
256-
257-
# Test case created directly using the atime code below (not adapted from any other benchmark), based on the issue/fix PR https://github.com/Rdatatable/data.table/pull/5054#issue-930603663 "melt should be more efficient when there are missing input columns."
254+
# Test case created directly using the atime code below (not adapted from any other benchmark), based on the PR Removes unnecessary data.table call from as.data.table.array https://github.com/Rdatatable/data.table/pull/7010
258255
"as.data.table.array improved in #7010" = atime::atime_test(
259256
setup = {
260257
dims = c(50, 50, 300, 10)
261258
arr = array(1:prod(dims), dim = dims)
262259
},
263260
expr = data.table:::as.data.table(arr),
264-
Slow = "73d79edf8ff8c55163e90631072192301056e336",
265-
Fast = "8397dc3c993b61a07a81c786ca68c22bc589befc"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue # Test case created directly using the atime code below (not adapted from any other benchmark), based on the issue/fix PR https://github.com/Rdatatable/data.table/pull/5054#issue-930603663 "melt should be more efficient when there are missing input columns."
261+
Slow = "73d79edf8ff8c55163e90631072192301056e336", # Parent of the first commit https://github.com/Rdatatable/data.table/tree/73d79edf8ff8c55163e90631072192301056e336
262+
Fast = "8397dc3c993b61a07a81c786ca68c22bc589befc"), # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/5054) that fixes the issue
266263

264+
tests=extra.test.list)
267265
# nolint end: undesirable_operator_linter.
268266

269267

0 commit comments

Comments
 (0)