Skip to content

Commit 4bf82ba

Browse files
committed
glci-san: fail if worse than NOTE
Previously, failure was only triggered by non-zero exit code from R CMD check, which is not strict enough.
1 parent af91201 commit 4bf82ba

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.gitlab-ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,9 @@ test-lin-dev-clang-san:
233233
- |
234234
res1=0; ASAN_OPTIONS=detect_leaks=1 R CMD check --no-manual $(ls -1t data.table_*.tar.gz | head -n 1) || res1=$?
235235
res2=0; perl -nle '(print, $a=1) if /: runtime error: |ERROR: LeakSanitizer/../SUMMARY.*Sanitizer/ }{ exit $a' data.table.Rcheck/**/*.Rout* || res2=$?
236+
res3=0; tail -n 1 data.table.Rcheck/00check.log | grep -q -e '^Status: [0-9]* NOTEs*$' -e '^Status: OK$' || res3=$?
236237
# fail if R CMD check had failed or if sanitizer output found
237-
if [ $res1 -ne 0 ] || [ $res2 -ne 0 ]; then exit 1; fi
238+
if [ $res1 -ne 0 ] || [ $res2 -ne 0 ] || [ $res3 -ne 0 ]; then exit 1; fi
238239
239240
test-lin-dev-gcc-san:
240241
<<: *test-lin
@@ -250,8 +251,9 @@ test-lin-dev-gcc-san:
250251
- |
251252
res1=0; ASAN_OPTIONS=detect_leaks=1 R CMD check --no-manual $(ls -1t data.table_*.tar.gz | head -n 1) || res1=$?
252253
res2=0; perl -nle '(print, $a=1) if /: runtime error: |ERROR: LeakSanitizer/../SUMMARY.*Sanitizer/ }{ exit $a' data.table.Rcheck/**/*.Rout* || res2=$?
254+
res3=0; tail -n 1 data.table.Rcheck/00check.log | grep -q -e '^Status: [0-9]* NOTEs*$' -e '^Status: OK$' || res3=$?
253255
# fail if R CMD check had failed or if sanitizer output found
254-
if [ $res1 -ne 0 ] || [ $res2 -ne 0 ]; then exit 1; fi
256+
if [ $res1 -ne 0 ] || [ $res2 -ne 0 ] || [ $res3 -ne 0 ]; then exit 1; fi
255257
256258
.test-win-template: &test-win
257259
<<: *test

0 commit comments

Comments
 (0)