remove repetition by extra temp var

jangorecki · ben-schwen · web-flow · commit 4ce502cb336f · 2024-01-12T15:55:06.000+01:00
Co-authored-by: Benjamin Schwendinger &lt;52290390+ben-schwen@users.noreply.github.com&gt;
diff --git a/src/froll.c b/src/froll.c
@@ -399,9 +399,10 @@ inline void wmax(double *x, uint64_t o, int k, double *w, uint64_t *iw, bool nar
   if (narm) {
     for (int i=0; i<k; i++) {
       //Rprintf("wmax iter %d, offset %d, first x val %f, testing x[o+i-k+1] >= w[0]: x[%d-%d+1] >= w[0]: %f >= %f: %d\n", i, o, x[o], i, k, x[o+i-k+1], w[0], x[o+i-k+1] >= w[0]);
-      if (x[o+i-k+1] >= w[0]) { // this never true if all x NAs and narm=TRUE
-        iw[0] = o+i-k+1;
-        w[0] = x[iw[0]];
+      const uint64_t ii = o+i-k+1;
+      if (x[ii] >= w[0]) { // this never true if all x NAs and narm=TRUE
+        iw[0] = ii;
+        w[0] = x[ii];
       }
     }
   } else {

Original file line number	Diff line number	Diff line change
`@@ -399,9 +399,10 @@ inline void wmax(double x, uint64_t o, int k, double w, uint64_t *iw, bool nar`
`399`	`399`	`if (narm) {`
`400`	`400`	`for (int i=0; i<k; i++) {`
`401`	`401`	`//Rprintf("wmax iter %d, offset %d, first x val %f, testing x[o+i-k+1] >= w[0]: x[%d-%d+1] >= w[0]: %f >= %f: %d\n", i, o, x[o], i, k, x[o+i-k+1], w[0], x[o+i-k+1] >= w[0]);`
`402`		`- if (x[o+i-k+1] >= w[0]) { // this never true if all x NAs and narm=TRUE`
`403`		`- iw[0] = o+i-k+1;`
`404`		`- w[0] = x[iw[0]];`
	`402`	`+ const uint64_t ii = o+i-k+1;`
	`403`	`+ if (x[ii] >= w[0]) { // this never true if all x NAs and narm=TRUE`
	`404`	`+ iw[0] = ii;`
	`405`	`+ w[0] = x[ii];`
`405`	`406`	`}`
`406`	`407`	`}`
`407`	`408`	`} else {`