revert fcast modifications

Mukulyadav2004 · web-flow · commit 4d283bac0b7a · 2025-08-23T04:34:22.000+05:30
diff --git a/R/fcast.R b/R/fcast.R
@@ -186,7 +186,11 @@ dcast.data.table = function(data, formula, fun.aggregate = NULL, sep = "_", ...,
     maybe_err = function(list.of.columns) {
       if (!all(lengths(list.of.columns) == 1L)) {
         msg = gettext("Aggregating functions should take a vector as input and return a single value (length=1), but they do not, so the result is undefined. Please fix by modifying your function so that a single value is always returned.")
-        stop(msg, domain=NA, call. = FALSE)
+        if (is.null(fill)) { # TODO change to always stopf #6329
+          stop(msg, domain=NA, call. = FALSE)
+        } else {
+          warning(msg, domain=NA, call. = FALSE)
+        }
       }
       list.of.columns
     }

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,11 @@ dcast.data.table = function(data, formula, fun.aggregate = NULL, sep = "_", ...,`
`186`	`186`	`maybe_err = function(list.of.columns) {`
`187`	`187`	`if (!all(lengths(list.of.columns) == 1L)) {`
`188`	`188`	`msg = gettext("Aggregating functions should take a vector as input and return a single value (length=1), but they do not, so the result is undefined. Please fix by modifying your function so that a single value is always returned.")`
`189`		`- stop(msg, domain=NA, call. = FALSE)`
	`189`	`+ if (is.null(fill)) { # TODO change to always stopf #6329`
	`190`	`+ stop(msg, domain=NA, call. = FALSE)`
	`191`	`+ } else {`
	`192`	`+ warning(msg, domain=NA, call. = FALSE)`
	`193`	`+ }`
`190`	`194`	`}`
`191`	`195`	`list.of.columns`
`192`	`196`	`}`