codecov

Author: jangorecki

R/frollapply.R

@@ -15,7 +15,7 @@ simplifylist = function(x, fill, ansmask) {
         ans.ut = "double"
       } else if ("integer" %in% ans.ut) {
         if ("logical" %in% ans.ut)
-          x[ansmask & all.t=="logical"] = lapply(x[ansmask & all.t=="logical"], as.logical) ## coerce logical to integer
+          x[ansmask & all.t=="logical"] = lapply(x[ansmask & all.t=="logical"], as.integer) ## coerce logical to integer
         else
           internal_error("simplifylist aligning return types, at that place there should have been some logical types in the answer") # nocov
         ans.ut = "integer"
@@ -51,8 +51,6 @@ simplifylist = function(x, fill, ansmask) {
       return(rbindlist(x))
     if (equal.lengths(x)) ## same length lists: list(list(1:2, 1:2), list(2:3, 2:3))
       return(rbindlist(x))
-    if (all(vapply_1i(unique(lengths(x)), function(x) length(unique(x)), use.names=FALSE) == 1L)) ## within each x column lengths the same, each could be DF: list(list(1, 2), list(1:2, 2:3))
-      return(rbindlist(x))
   }
   ## not simplified, return as is
   # not length stable

inst/tests/froll.Rraw

@@ -1783,6 +1783,10 @@ test(6010.751, frollapply(FUN=median, adaptive=TRUE, list(1:3,2:4), list(c(2,0,2
 test(6010.752, frollapply(FUN=median, adaptive=TRUE, 1:3, c(2,0,2), fill=99), c(99,NA_real_,2.5))
 test(6010.753, frollapply(FUN=median, adaptive=TRUE, c(1L,2L,4L), c(2,0,2), fill=99L), c(99,NA_real_,3))
 test(6010.754, frollapply(FUN=median, adaptive=TRUE, c(1L,2L,3L), c(2,0,2), fill=99), c(99,NA_real_,2.5))
+test(6010.755, frollapply(1:2, 1, function(i) if (i==1L) 1L else FALSE), c(1L,0L))
+test(6010.756, frollapply(1:3, 2, fill=9, function(i) if (i[1L]==1L) 1L else FALSE), c(9L,1L,0L)) ## matches fun answer
+test(6010.757, frollapply(1:3, 2, fill=9L, function(i) if (i[1L]==1L) 1 else FALSE), c(9,1,0)) ## matches fun answer
+test(6010.758, frollapply(1:3, 2, fill=0, function(i) TRUE), c(FALSE,TRUE,TRUE)) ## matches fun answer
 
 #### mutlithreading throttle caveats from manual: copy, fixing .internal.selfref
 use.fork = .Platform$OS.type!="windows" && getDTthreads()>1L