don't reuse overloaded name 'let'

Author: MichaelChirico

inst/tests/tests.Rraw

@@ -7078,40 +7078,40 @@ setkey(y)
 test(1483.4, y[x], data.table(country="US", key="country"))
 
 # 5361 merge on character and factor should only have key(x) if result is really sorted
-let = c("a", "b", "c")
+lett = c("a", "b", "c")
 rlet = c("c", "b", "a")
 x = data.table(i=rlet)
-y = data.table(i=factor(let, levels=rlet), key="i")
+y = data.table(i=factor(lett, levels=rlet), key="i")
 test(1483.51, x[y, on="i"], x)
 test(1483.52, y[x, on="i"], x)
-test(1483.53, merge(x, y, by="i"), data.table(i=let, key="i"))
-test(1483.54, merge(y, x, by="i"), data.table(i=let, key="i"))
+test(1483.53, merge(x, y, by="i"), data.table(i=lett, key="i"))
+test(1483.54, merge(y, x, by="i"), data.table(i=lett, key="i"))
 x = data.table(i1=1:3, i2=rlet)
-y = data.table(i1=1:3, i2=factor(let, levels=rlet), key=c("i1", "i2"))
-test(1483.55, x[y, on=c("i1", "i2")], data.table(i1=1:3, i2=let))
+y = data.table(i1=1:3, i2=factor(lett, levels=rlet), key=c("i1", "i2"))
+test(1483.55, x[y, on=c("i1", "i2")], data.table(i1=1:3, i2=lett))
 test(1483.56, y[x, on=c("i1", "i2")], x)
 test(1483.57, merge(x, y, by=c("i1", "i2")), data.table(i1=2L, i2="b", key=c("i1", "i2")))
 test(1483.58, merge(y, x, by=c("i1", "i2")), data.table(i1=2L, i2="b", key=c("i1", "i2")))
 
 x = data.table(i=rlet, key="i")
-y = data.table(i=factor(let, levels=rlet))
+y = data.table(i=factor(lett, levels=rlet))
 test(1483.61, x[y, on="i"], x)
-test(1483.62, y[x, on="i"], data.table(i=let))
-test(1483.63, merge(x, y, by="i"), data.table(i=let, key="i"))
-test(1483.64, merge(y, x, by="i"), data.table(i=let, key="i"))
+test(1483.62, y[x, on="i"], data.table(i=lett))
+test(1483.63, merge(x, y, by="i"), data.table(i=lett, key="i"))
+test(1483.64, merge(y, x, by="i"), data.table(i=lett, key="i"))
 x = data.table(i1=1:3, i2=rlet, key=c("i1", "i2"))
-y = data.table(i1=1:3, i2=factor(let, levels=rlet))
-test(1483.65, x[y, on=c("i1", "i2")], data.table(i1=1:3, i2=let))
+y = data.table(i1=1:3, i2=factor(lett, levels=rlet))
+test(1483.65, x[y, on=c("i1", "i2")], data.table(i1=1:3, i2=lett))
 test(1483.66, y[x, on=c("i1", "i2")], data.table(i1=1:3, i2=rlet))
 test(1483.67, merge(x, y, by=c("i1", "i2")), data.table(i1=2L, i2="b", key=c("i1", "i2")))
 test(1483.68, merge(y, x, by=c("i1", "i2")), data.table(i1=2L, i2="b", key=c("i1", "i2")))
 
 x = data.table(i=rlet, a=rlet)
-y = data.table(i=factor(let, levels=rlet), b=let, key="i")
+y = data.table(i=factor(lett, levels=rlet), b=lett, key="i")
 test(1483.71, x[y, on="i"], data.table(i=rlet, a=rlet, b=rlet))
 test(1483.72, y[x, on="i"], data.table(i=rlet, b=rlet, a=rlet))
-test(1483.73, merge(x, y, by="i"), data.table(i=let, a=let, b=let, key="i"))
-test(1483.74, merge(y, x, by="i"), data.table(i=let, b=let, a=let, key="i"))
+test(1483.73, merge(x, y, by="i"), data.table(i=lett, a=lett, b=lett, key="i"))
+test(1483.74, merge(y, x, by="i"), data.table(i=lett, b=lett, a=lett, key="i"))
 
 some_letters <- c("c", "b", "a")
 some_more_letters <- rep(c("a", "b", "c"), 2L)
@@ -18578,8 +18578,8 @@ test(2251.15, dim(fread(text, fill=Inf)), c(9L, 9L))
 
 .datatable.aware = FALSE
 dt = data.table(a = 1L)
-test(2252.1, dt[, b:=2L], error = "\\[ was called on a data.table.*not data.table-aware.*':='")
-test(2252.2, dt[, let(b=2L)], error = "\\[ was called on a data.table.*not data.table-aware.*'let'")
+test(2252.1, dt[, b:=2L], error = "\\[ was called on a dtest(2252.2, dt[, let(b=2L)], error = "\\[ was called on a data.table.*not data.table-aware.*'let'ata.table.*not data.table-aware.*':='")
+")
 rm(.datatable.aware)
 
 # tests for trunc.char handling wide characters # 5096