add PROTECT for getAttrib rbindlist

ben-schwen · ben-schwen · commit 6130c6c795a3 · 2024-12-02T11:34:50.000+01:00
diff --git a/src/rbindlist.c b/src/rbindlist.c
@@ -305,7 +305,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor
         if (isOrdered(thisCol)) {
           orderedFactor = true;
           int thisLen = length(getAttrib(thisCol, R_LevelsSymbol));
-          if (thisLen>longestLen) { longestLen=thisLen; longestLevels=getAttrib(thisCol, R_LevelsSymbol); /*for warnings later ...*/longestW=w; longestI=i; }
+          if (thisLen>longestLen) { longestLen=thisLen; longestLevels=PROTECT(getAttrib(thisCol, R_LevelsSymbol)); nprotect++; /*for warnings later ...*/longestW=w; longestI=i; }
         }
       } else if (!isString(thisCol)) anyNotStringOrFactor=true;  // even for length 0 columns for consistency; test 2113.3
       if (INHERITS(thisCol, char_integer64)) {

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ SEXP rbindlist(SEXP l, SEXP usenamesArg, SEXP fillArg, SEXP idcolArg, SEXP ignor`
`305`	`305`	`if (isOrdered(thisCol)) {`
`306`	`306`	`orderedFactor = true;`
`307`	`307`	`int thisLen = length(getAttrib(thisCol, R_LevelsSymbol));`
`308`		`- if (thisLen>longestLen) { longestLen=thisLen; longestLevels=getAttrib(thisCol, R_LevelsSymbol); /for warnings later .../longestW=w; longestI=i; }`
	`308`	`+ if (thisLen>longestLen) { longestLen=thisLen; longestLevels=PROTECT(getAttrib(thisCol, R_LevelsSymbol)); nprotect++; /for warnings later .../longestW=w; longestI=i; }`
`309`	`309`	`}`
`310`	`310`	`} else if (!isString(thisCol)) anyNotStringOrFactor=true; // even for length 0 columns for consistency; test 2113.3`
`311`	`311`	`if (INHERITS(thisCol, char_integer64)) {`