add comment

ben-schwen · ben-schwen · commit 6143ef76d150 · 2024-11-30T15:54:11.000+01:00
diff --git a/R/bmerge.R b/R/bmerge.R
@@ -81,6 +81,7 @@ bmerge = function(i, x, icols, xcols, roll, rollends, nomatch, mult, ops, verbos
       }
       stopf("Incompatible join types: %s (%s) and %s (%s). Factor columns must join to factor or character columns.", xname, x_merge_type, iname, i_merge_type)
     }
+    # we check factors first to cater for the case when trying to do rolling joins on factors
     if (x_merge_type == i_merge_type) {
       if (verbose) catf("%s has same type (%s) as %s. No coercion needed.\n", iname, x_merge_type, xname)
       next

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ bmerge = function(i, x, icols, xcols, roll, rollends, nomatch, mult, ops, verbos`
`81`	`81`	`}`
`82`	`82`	`stopf("Incompatible join types: %s (%s) and %s (%s). Factor columns must join to factor or character columns.", xname, x_merge_type, iname, i_merge_type)`
`83`	`83`	`}`
	`84`	`+ # we check factors first to cater for the case when trying to do rolling joins on factors`
`84`	`85`	`if (x_merge_type == i_merge_type) {`
`85`	`86`	`if (verbose) catf("%s has same type (%s) as %s. No coercion needed.\n", iname, x_merge_type, xname)`
`86`	`87`	`next`