Skip to content

Commit 6db07cd

Browse files
committed
add atime test
1 parent b6ad1a4 commit 6db07cd

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

.ci/atime/tests.R

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,4 +287,19 @@ test.list <- atime::atime_test_list(
287287
Fast = "c0b32a60466bed0e63420ec105bc75c34590865e"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7144/commits) that uses a much faster implementation
288288

289289
tests=extra.test.list)
290+
291+
# Regression introduced in #7404 (grouped by factor).
292+
"DT[by] max regression fixed in #7480" = atime::atime_test(
293+
N = as.integer(10^seq(3, 5, by=0.5)),
294+
setup = {
295+
dt = data.table(
296+
id = as.factor(rep(seq_len(N), each = 100L)),
297+
V1 = 1L
298+
)
299+
},
300+
expr = data.table:::`[.data.table`(dt, , base::max(V1, na.rm = TRUE), by = id),
301+
Before = "476de7e3",
302+
Regression = "6f49bf1",
303+
Fixed = "b6ad1a4",
304+
seconds.limit = 1),
290305
# nolint end: undesirable_operator_linter.

0 commit comments

Comments
 (0)