Skip to content

Commit 6e458bb

Browse files
committed
Drop R-devel (pre 4.5.0) compatibility definitions
During the R-4.5.0 development cycle, R introduced a number of entry points which we were required to use, necessitating checks for SVN revision numbers for compatibility with older versions of R-devel. Since R-4.5.0 has been released, remove the checks.
1 parent 113c3fa commit 6e458bb

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/data.table.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
# define RAW_RO RAW
1414
# define LOGICAL_RO LOGICAL
1515
#endif
16-
// TODO: remove the `R_SVN_VERSION` check when R 4.5.0 is released (circa Apr. 2025)
17-
#if R_VERSION < R_Version(4, 5, 0) || R_SVN_REVISION < 86702
16+
#if R_VERSION < R_Version(4, 5, 0)
1817
# define isDataFrame(x) isFrame(x) // #6180
1918
#endif
2019
#include <Rinternals.h>
@@ -38,8 +37,7 @@
3837
/* we mean the encoding bits, not CE_NATIVE in a UTF-8 locale */
3938
#define IS_UTF8(x) (getCharCE(x) == CE_UTF8)
4039
#define IS_LATIN(x) (getCharCE(x) == CE_LATIN1)
41-
// TODO: remove the `R_SVN_VERSION` check when R 4.5.0 is released (circa Apr. 2025)
42-
#if R_VERSION < R_Version(4, 5, 0) || R_SVN_REVISION < 86789
40+
#if R_VERSION < R_Version(4, 5, 0)
4341
# define IS_ASCII(x) (LEVELS(x) & 64)
4442
#else
4543
# define IS_ASCII(x) (Rf_charIsASCII(x)) // no CE_ASCII

0 commit comments

Comments
 (0)