change var name and dont run optional on github

Author: ben-schwen

.github/workflows/R-CMD-check-occasional.yaml

@@ -42,7 +42,7 @@ jobs:
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
-      RunAllDataTableTests: yes
+      RUN_ALL_DATATABLE_TESTS: yes
 
     steps:
       - name: Set locale

.github/workflows/R-CMD-check.yaml

@@ -38,7 +38,7 @@ jobs:
       RSPM: ${{ matrix.config.rspm }}
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       _R_CHECK_RD_CHECKRD_MINLEVEL_: -Inf
-      RunAllDataTableTests: yes
+      RUN_ALL_DATATABLE_TESTS: yes
 
     steps:
       - uses: actions/checkout@v4

.gitlab-ci.yml

@@ -13,7 +13,7 @@ variables:
   TZ: "UTC"  ## to avoid 'Failed to create bus connection' from timedatectl via Sys.timezone() on Docker with R 3.4.
              ## Setting TZ for all GLCI jobs to isolate them from timezone. We could have a new GLCI job to test under
              ## a non-UTC timezone, although, that's what we do routinely in dev.
-  RunAllDataTableTests: "yes"  ## run optional tests in CI
+  RUN_ALL_DATATABLE_TESTS: "yes"  ## run optional tests in CI
   R_REL_VERSION:  "4.5" # only raise when RTOOLS for REL is available
   R_REL_WIN_BIN:  "https://cloud.r-project.org/bin/windows/base/old/4.5.0/R-4.5.0-win.exe"
   R_DEV_VERSION:  "4.6"

R/test.data.table.R

@@ -2,8 +2,8 @@ test.data.table = function(script="tests.Rraw", verbose=FALSE, pkg=".", silent=F
                            memtest=Sys.getenv("TEST_DATA_TABLE_MEMTEST", 0L), memtest.id=NULL, optional=FALSE) {
   stopifnot(isTRUEorFALSE(verbose), isTRUEorFALSE(silent), isTRUEorFALSE(showProgress), isTRUEorFALSE(optional))
 
-  # Skip optional tests unless RunAllDataTableTests is set
-  if (optional && Sys.getenv("RunAllDataTableTests") != "yes") {
+  # Skip optional tests unless RUN_ALL_DATATABLE_TESTS is set
+  if (optional && Sys.getenv("RUN_ALL_DATATABLE_TESTS") != "yes") {
     return(invisible(TRUE))
   }
 

man/test.data.table.Rd

@@ -21,7 +21,7 @@ test.data.table(script = "tests.Rraw", verbose = FALSE, pkg = ".",
 \item{testPattern}{ When present, a regular expression tested against the number of each test for inclusion. Useful for running only a small portion of a large test script. }
 \item{memtest}{ Measure and report memory usage of tests (1:gc before ps, 2:gc after ps) rather than time taken (0) by default. Intended for and tested on Linux. See PR #5515 for more details. }
 \item{memtest.id}{ An id for which to print memory usage for every sub id. May be a range of ids. }
-\item{optional}{ If \code{TRUE}, the test will only run when the environment variable \code{RunAllDataTableTests} is set to \code{"yes"}. This allows certain optional tests to be skipped on CRAN but run in development or CI environments. }
+\item{optional}{ If \code{TRUE}, the test will only run when the environment variable \code{RUN_ALL_DATATABLE_TESTS} is set to \code{"yes"}. This allows certain optional tests to be skipped on CRAN but run in development or CI environments. }
 }
 \details{
   Runs a series of tests. These can be used to see features and examples of usage, too. Running test.data.table will tell you the full location of the test file(s) to open.